FreeChainXenon/binutils-gdb
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

[gdb] Fix regoff_t incompatibility

Browse source 
I did an experiment with importing the regex module in gnulib, and trying to
build gdb.

The first problem I ran into was that:
- regoff_t was defined as long int, and
- the address of a regoff_t variable i in ui_file_style::parse was passed
  as int * to function extended_color.

Fix this by changing the types of some function parameters of functions
read_semi_number and extended_color from int * to regoff_t *.

Tested on x86_64-linux.

gdb/ChangeLog:

2021-04-13  Tom de Vries  <tdevries@suse.de>

	* ui-style.c (read_semi_number, extended_color): Change idx parameter
	type to regoff_t *.
This commit is contained in:
Tom de Vries 2021-04-13 17:38:53 +02:00
parent d9d2ef05f1
commit 329534fda7
2 changed files with 7 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
gdb/ChangeLog
View file

@ -1,3 +1,8 @@
2021-04-13 Tom de Vries <tdevries@suse.de>
* ui-style.c (read_semi_number, extended_color): Change idx parameter
type to regoff_t *.
2021-04-13 Luis Machado <luis.machado@linaro.org>
* rs6000-tdep.c (ppc_displaced_step_fixup): Use %s to print

4
gdb/ui-style.c
View file

@ -169,7 +169,7 @@ ui_file_style::to_ansi () const
characters read and put the number into *NUM. */
static bool
read_semi_number (const char *string, int *idx, long *num)
read_semi_number (const char *string, regoff_t *idx, long *num)
{
if (string[*idx] != ';')
return false;
@ -186,7 +186,7 @@ read_semi_number (const char *string, int *idx, long *num)
sequence; that is, and 8- or 24- bit color. */
static bool
extended_color (const char *str, int *idx, ui_file_style::color *color)
extended_color (const char *str, regoff_t *idx, ui_file_style::color *color)
{
long value;