FreeChainXenon/binutils-gdb
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

gdb: remove bpstat typedef, rename bpstats to bpstat

Browse source 
I don't find that the bpstat typedef, which hides a pointer, is
particularly useful.  In fact, it confused me many times, and I just see
it as something to remember that adds cognitive load.  Also, with C++,
we might want to be able to pass bpstats objects by const-reference, not
necessarily by pointer.

So, remove the bpstat typedef and rename struct bpstats to bpstat (since
it represents one bpstat, it makes sense that it is singular).

Change-Id: I52e763b6e54ee666a9e045785f686d37b4f5f849
This commit is contained in:
Simon Marchi 2021-11-05 15:29:20 -04:00
parent 9be90c6894
commit 313f3b21cb
23 changed files with 115 additions and 117 deletions
Download patch file Download diff file Expand all files Collapse all files

2
gdb/python/py-finishbreakpoint.c
View file

@ -378,7 +378,7 @@ bpfinishpy_detect_out_scope_cb (struct breakpoint *b,
out of the scope of any FinishBreakpoint before it has been hit. */
static void
bpfinishpy_handle_stop (struct bpstats *bs, int print_frame)
bpfinishpy_handle_stop (struct bpstat *bs, int print_frame)
{
gdbpy_enter enter_py (get_current_arch (), current_language);

2
gdb/python/py-inferior.c
View file

@ -74,7 +74,7 @@ static const struct inferior_data *infpy_inf_data_key;
} while (0)
static void
python_on_normal_stop (struct bpstats *bs, int print_frame)
python_on_normal_stop (struct bpstat *bs, int print_frame)
{
enum gdb_signal stop_signal;

4
gdb/python/py-stopevent.c
View file

@ -35,12 +35,12 @@ create_stop_event_object (PyTypeObject *py_type)
returns -1. */
int
emit_stop_event (struct bpstats *bs, enum gdb_signal stop_signal)
emit_stop_event (struct bpstat *bs, enum gdb_signal stop_signal)
{
gdbpy_ref<> stop_event_obj;
gdbpy_ref<> list;
PyObject *first_bp = NULL;
struct bpstats *current_bs;
struct bpstat *current_bs;
if (evregpy_no_listeners_p (gdb_py_events.stop))
return 0;

2
gdb/python/py-stopevent.h
View file

@ -25,7 +25,7 @@
extern gdbpy_ref<> create_stop_event_object (PyTypeObject *py_type);
extern void stop_evpy_dealloc (PyObject *self);
extern int emit_stop_event (struct bpstats *bs,
extern int emit_stop_event (struct bpstat *bs,
enum gdb_signal stop_signal);
extern gdbpy_ref<> create_breakpoint_event_object (PyObject *breakpoint_list,

2
gdb/python/python-internal.h
View file

@ -295,7 +295,7 @@ struct block;
struct value;
struct language_defn;
struct program_space;
struct bpstats;
struct bpstat;
struct inferior;
extern int gdb_python_initialized;