FreeChainXenon/binutils-gdb
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Rename regcache_cooked_read_ftype and make a function_view

Browse source 
regcache_cooked_read_ftype can be converted to a function_view, which
allows us to use lambda functions and therefore avoid having to pass an
opaque pointer parameter.

Adjusting the fallouts showed that the "const regcache &" passed to the
readonly_detached_regcache constructor is cast to non-const in
do_cooked_read.  I changed the constructor parameter to be non-const.

Finally, I renamed the typedef from regcache_cooked_read_ftype to
register_read_ftype, since there is nothing that forces us to use it
only for regcaches nor cooked registers.

gdb/ChangeLog:

	* regcache.h (regcache_cooked_read_ftype): Rename to...
	(register_read_ftype): ...this, change type to function_view.
	(class reg_buffer) <save>: Remove src parameter.
	(readonly_detached_regcache) <readonly_detached_regcache>: Make
	parameter non-const in first overload.  Remove src parameter in
	second overload.
	* regcache.c (do_cooked_read): Remove.
	(readonly_detached_regcache::readonly_detached_regcache): Make
	parameter non-const, adjust call to other constructor.
	(reg_buffer::save): Remove src parameter.
	* frame.c (do_frame_register_read): Remove.
	(frame_save_as_regcache): Use lambda function.
	* ppc-linux-tdep.c (ppu2spu_unwind_register): Change type of src
	parameter to ppu2spu_data *.
	(ppu2spu_sniffer): Use lambda function.
This commit is contained in:
Simon Marchi 2018-06-20 12:49:03 -04:00 • committed by Simon Marchi
parent f00674fe07
commit 302abd6e9f
5 changed files with 47 additions and 38 deletions
Download patch file Download diff file Expand all files Collapse all files

20
gdb/frame.c
View file

@ -1024,21 +1024,19 @@ get_frame_func (struct frame_info *this_frame)
return pc;
}
static enum register_status
do_frame_register_read (void *src, int regnum, gdb_byte *buf)
{
if (!deprecated_frame_register_read ((struct frame_info *) src, regnum, buf))
return REG_UNAVAILABLE;
else
return REG_VALID;
}
std::unique_ptr<readonly_detached_regcache>
frame_save_as_regcache (struct frame_info *this_frame)
{
auto cooked_read = [this_frame] (int regnum, gdb_byte *buf)
{
if (!deprecated_frame_register_read (this_frame, regnum, buf))
return REG_UNAVAILABLE;
else
return REG_VALID;
};
std::unique_ptr<readonly_detached_regcache> regcache
(new readonly_detached_regcache (get_frame_arch (this_frame),
do_frame_register_read, this_frame));
(new readonly_detached_regcache (get_frame_arch (this_frame), cooked_read));
return regcache;
}