Skip a few tests on targets that can't use the "run" commmand.
These tests want to use raw "run", so skip them on targets that can't do that. Also adds a small utility procedure that clearly conveys intent instead of explicitly checking use_gdb_stub in the testcases. This makes sure these testcases continue to be skipped with --target_board=native-gdbserver once that board stops setting is_remote. gdb/testsuite/ChangeLog: 2017-10-13 Pedro Alves <palves@redhat.com> * lib/gdb.exp (target_can_use_run_cmd): New procedure. * gdb.base/annota1.exp: Use it instead of is_remote. * gdb.base/annota3.exp: Use it instead of is_remote. * gdb.cp/annota2.exp: Use it instead of is_remote. * gdb.cp/annota3.exp: Use it instead of is_remote. * gdb.multi/bkpt-multi-exec.exp: Use it instead of is_remote.
This commit is contained in:
parent
50500caf81
commit
300b6685f1
7 changed files with 35 additions and 21 deletions
|
@ -1,3 +1,12 @@
|
|||
2017-10-13 Pedro Alves <palves@redhat.com>
|
||||
|
||||
* lib/gdb.exp (target_can_use_run_cmd): New procedure.
|
||||
* gdb.base/annota1.exp: Use it instead of is_remote.
|
||||
* gdb.base/annota3.exp: Use it instead of is_remote.
|
||||
* gdb.cp/annota2.exp: Use it instead of is_remote.
|
||||
* gdb.cp/annota3.exp: Use it instead of is_remote.
|
||||
* gdb.multi/bkpt-multi-exec.exp: Use it instead of is_remote.
|
||||
|
||||
2017-10-13 Pedro Alves <palves@redhat.com>
|
||||
|
||||
* gdb.base/testenv.exp: Check use_gdb_stub instead of is_remote.
|
||||
|
|
|
@ -16,12 +16,10 @@
|
|||
# This file was written by Elena Zannoni (ezannoni@cygnus.com)
|
||||
|
||||
|
||||
# are we on a target board? If so, don't run these tests.
|
||||
# note: this is necessary because we cannot use runto_main (which would
|
||||
# work for remote targets too) because of the different prompt we get
|
||||
# when using annotation level 2.
|
||||
# This testcase cannot use runto_main because of the different prompt
|
||||
# we get when using annotation level 2.
|
||||
#
|
||||
if [is_remote target] then {
|
||||
if ![target_can_use_run_cmd] {
|
||||
return 0
|
||||
}
|
||||
|
||||
|
|
|
@ -16,12 +16,10 @@
|
|||
# This file was written by Elena Zannoni (ezannoni@cygnus.com)
|
||||
|
||||
|
||||
# are we on a target board? If so, don't run these tests.
|
||||
# note: this is necessary because we cannot use runto_main (which would
|
||||
# work for remote targets too) because of the different prompt we get
|
||||
# when using annotation level 2.
|
||||
# This testcase cannot use runto_main because of the different prompt
|
||||
# we get when using annotation level 2.
|
||||
#
|
||||
if [is_remote target] then {
|
||||
if ![target_can_use_run_cmd] {
|
||||
return 0
|
||||
}
|
||||
|
||||
|
|
|
@ -29,12 +29,10 @@ if {[prepare_for_testing "failed to prepare" $testfile $srcfile \
|
|||
return -1
|
||||
}
|
||||
|
||||
# are we on a target board? If so, don't run these tests.
|
||||
# note: this is necessary because we cannot use runto_main (which would
|
||||
# work for remote targets too) because of the different prompt we get
|
||||
# when using annotation level 2.
|
||||
# This testcase cannot use runto_main because of the different prompt
|
||||
# we get when using annotation level 2.
|
||||
#
|
||||
if [is_remote target] then {
|
||||
if ![target_can_use_run_cmd] {
|
||||
return 0
|
||||
}
|
||||
|
||||
|
|
|
@ -29,12 +29,10 @@ if {[prepare_for_testing "failed to prepare" $testfile $srcfile \
|
|||
return -1
|
||||
}
|
||||
|
||||
# are we on a target board? If so, don't run these tests.
|
||||
# note: this is necessary because we cannot use runto_main (which would
|
||||
# work for remote targets too) because of the different prompt we get
|
||||
# when using annotation level 2.
|
||||
# This testcase cannot use runto_main because of the different prompt
|
||||
# we get when using annotation level 2.
|
||||
#
|
||||
if [is_remote target] then {
|
||||
if ![target_can_use_run_cmd] {
|
||||
return 0
|
||||
}
|
||||
|
||||
|
|
|
@ -13,7 +13,7 @@
|
|||
# You should have received a copy of the GNU General Public License
|
||||
# along with this program. If not, see <http://www.gnu.org/licenses/>.
|
||||
|
||||
if { [is_remote target] || ![isnative] } then {
|
||||
if ![target_can_use_run_cmd] {
|
||||
continue
|
||||
}
|
||||
|
||||
|
|
|
@ -226,6 +226,19 @@ proc delete_breakpoints {} {
|
|||
}
|
||||
}
|
||||
|
||||
# Returns true iff the target supports using the "run" command.
|
||||
|
||||
proc target_can_use_run_cmd {} {
|
||||
if [target_info exists use_gdb_stub] {
|
||||
# In this case, when we connect, the inferior is already
|
||||
# running.
|
||||
return 0
|
||||
}
|
||||
|
||||
# Assume yes.
|
||||
return 1
|
||||
}
|
||||
|
||||
# Generic run command.
|
||||
#
|
||||
# The second pattern below matches up to the first newline *only*.
|
||||
|
|
Loading…
Add table
Reference in a new issue