FreeChainXenon/binutils-gdb
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

2007-07-05 Michael Snyder <msnyder@access-company.com>

Browse source 
* event-top.c (cli_command_loop): Prompt string can (and should)
	be freed after call to readline (Coverity).  Also move local var
	declarations into block where they are used.

	* tui/tui-interp.c (tui_command_loop): Prompt string can (and
	should) be freed after call to readline (Coverity).  Also move
	local var declarations into block where they are used.
This commit is contained in:
Michael Snyder 2007-07-05 22:47:27 +00:00
parent 033ca630f7
commit 2ed23f5f14
3 changed files with 24 additions and 12 deletions
Download patch file Download diff file Expand all files Collapse all files

10
gdb/ChangeLog
View file

@ -1,3 +1,13 @@
2007-07-05 Michael Snyder <msnyder@access-company.com>
* event-top.c (cli_command_loop): Prompt string can (and should)
be freed after call to readline (Coverity). Also move local var
declarations into block where they are used.
* tui/tui-interp.c (tui_command_loop): Prompt string can (and
should) be freed after call to readline (Coverity). Also move
local var declarations into block where they are used.
2007-07-03 Andreas Schwab <schwab@suse.de> 2007-07-03 Andreas Schwab <schwab@suse.de>
* linux-nat.c (linux_nat_info_proc_cmd): Fix parsing of columns in * linux-nat.c (linux_nat_info_proc_cmd): Fix parsing of columns in

13
gdb/event-top.c
View file

@ -186,19 +186,20 @@ rl_callback_read_char_wrapper (gdb_client_data client_data)
void void
cli_command_loop (void) cli_command_loop (void)
{ {
int length;
char *a_prompt;
char *gdb_prompt = get_prompt ();
/* If we are using readline, set things up and display the first /* If we are using readline, set things up and display the first
prompt, otherwise just print the prompt. */ prompt, otherwise just print the prompt. */
if (async_command_editing_p) if (async_command_editing_p)
{ {
int length;
char *a_prompt;
char *gdb_prompt = get_prompt ();
/* Tell readline what the prompt to display is and what function it /* Tell readline what the prompt to display is and what function it
will need to call after a whole line is read. This also displays will need to call after a whole line is read. This also displays
the first prompt. */ the first prompt. */
length = strlen (PREFIX (0)) + strlen (gdb_prompt) + strlen (SUFFIX (0)) + 1; length = strlen (PREFIX (0))
a_prompt = (char *) xmalloc (length); + strlen (gdb_prompt) + strlen (SUFFIX (0)) + 1;
a_prompt = (char *) alloca (length);
strcpy (a_prompt, PREFIX (0)); strcpy (a_prompt, PREFIX (0));
strcat (a_prompt, gdb_prompt); strcat (a_prompt, gdb_prompt);
strcat (a_prompt, SUFFIX (0)); strcat (a_prompt, SUFFIX (0));

13
gdb/tui/tui-interp.c
View file

@ -119,19 +119,20 @@ tui_exec (void *data, const char *command_str)
static void static void
tui_command_loop (void *data) tui_command_loop (void *data)
{ {
int length;
char *a_prompt;
char *gdb_prompt = get_prompt ();
/* If we are using readline, set things up and display the first /* If we are using readline, set things up and display the first
prompt, otherwise just print the prompt. */ prompt, otherwise just print the prompt. */
if (async_command_editing_p) if (async_command_editing_p)
{ {
int length;
char *a_prompt;
char *gdb_prompt = get_prompt ();
/* Tell readline what the prompt to display is and what function /* Tell readline what the prompt to display is and what function
it will need to call after a whole line is read. This also it will need to call after a whole line is read. This also
displays the first prompt. */ displays the first prompt. */
length = strlen (PREFIX (0)) + strlen (gdb_prompt) + strlen (SUFFIX (0)) + 1; length = strlen (PREFIX (0))
a_prompt = (char *) xmalloc (length); + strlen (gdb_prompt) + strlen (SUFFIX (0)) + 1;
a_prompt = (char *) alloca (length);
strcpy (a_prompt, PREFIX (0)); strcpy (a_prompt, PREFIX (0));
strcat (a_prompt, gdb_prompt); strcat (a_prompt, gdb_prompt);
strcat (a_prompt, SUFFIX (0)); strcat (a_prompt, SUFFIX (0));