PR binutils/16218

* dwarf.c (read_and_display_attr_value): Only print a tab
	character if it preceeds further text.

	* binutils-all/dw2-1.W:	Update expected objdump output.
	* binutils-all/i386/compressed-1a.d: Likewise.
	* binutils-all/objdump.W: Likewise.
	* binutils-all/x86-64/compressed-1a.d: Likewise.

	* gas/elf/dwarf2-1.d: Update expected objdump output.
	* gas/elf/dwarf2-2.d: Likewise.
	* gas/i386/dw2-compress-1.d: Likewise.
This commit is contained in:
Nick Clifton 2013-12-20 13:52:23 +00:00
parent 99d190fac4
commit 2e9e81a8f5
11 changed files with 139 additions and 111 deletions

View file

@ -1,3 +1,9 @@
2013-12-20 Nick Clifton <nickc@redhat.com>
PR binutils/16218
* dwarf.c (read_and_display_attr_value): Only print a tab
character if it preceeds further text.
2013-12-19 Tom Tromey <tromey@redhat.com> 2013-12-19 Tom Tromey <tromey@redhat.com>
* dwarf.c (fetch_indirect_string): Don't bias by section address. * dwarf.c (fetch_indirect_string): Don't bias by section address.

View file

@ -1805,11 +1805,10 @@ read_and_display_attr_value (unsigned long attribute,
return data; return data;
/* For some attributes we can display further information. */ /* For some attributes we can display further information. */
printf ("\t");
switch (attribute) switch (attribute)
{ {
case DW_AT_inline: case DW_AT_inline:
printf ("\t");
switch (uvalue) switch (uvalue)
{ {
case DW_INL_not_inlined: case DW_INL_not_inlined:
@ -1832,6 +1831,7 @@ read_and_display_attr_value (unsigned long attribute,
break; break;
case DW_AT_language: case DW_AT_language:
printf ("\t");
switch (uvalue) switch (uvalue)
{ {
/* Ordered by the numeric value of these constants. */ /* Ordered by the numeric value of these constants. */
@ -1875,6 +1875,7 @@ read_and_display_attr_value (unsigned long attribute,
break; break;
case DW_AT_encoding: case DW_AT_encoding:
printf ("\t");
switch (uvalue) switch (uvalue)
{ {
case DW_ATE_void: printf ("(void)"); break; case DW_ATE_void: printf ("(void)"); break;
@ -1915,6 +1916,7 @@ read_and_display_attr_value (unsigned long attribute,
break; break;
case DW_AT_accessibility: case DW_AT_accessibility:
printf ("\t");
switch (uvalue) switch (uvalue)
{ {
case DW_ACCESS_public: printf ("(public)"); break; case DW_ACCESS_public: printf ("(public)"); break;
@ -1927,6 +1929,7 @@ read_and_display_attr_value (unsigned long attribute,
break; break;
case DW_AT_visibility: case DW_AT_visibility:
printf ("\t");
switch (uvalue) switch (uvalue)
{ {
case DW_VIS_local: printf ("(local)"); break; case DW_VIS_local: printf ("(local)"); break;
@ -1937,6 +1940,7 @@ read_and_display_attr_value (unsigned long attribute,
break; break;
case DW_AT_virtuality: case DW_AT_virtuality:
printf ("\t");
switch (uvalue) switch (uvalue)
{ {
case DW_VIRTUALITY_none: printf ("(none)"); break; case DW_VIRTUALITY_none: printf ("(none)"); break;
@ -1947,6 +1951,7 @@ read_and_display_attr_value (unsigned long attribute,
break; break;
case DW_AT_identifier_case: case DW_AT_identifier_case:
printf ("\t");
switch (uvalue) switch (uvalue)
{ {
case DW_ID_case_sensitive: printf ("(case_sensitive)"); break; case DW_ID_case_sensitive: printf ("(case_sensitive)"); break;
@ -1958,6 +1963,7 @@ read_and_display_attr_value (unsigned long attribute,
break; break;
case DW_AT_calling_convention: case DW_AT_calling_convention:
printf ("\t");
switch (uvalue) switch (uvalue)
{ {
case DW_CC_normal: printf ("(normal)"); break; case DW_CC_normal: printf ("(normal)"); break;
@ -1973,6 +1979,7 @@ read_and_display_attr_value (unsigned long attribute,
break; break;
case DW_AT_ordering: case DW_AT_ordering:
printf ("\t");
switch (uvalue) switch (uvalue)
{ {
case -1: printf (_("(undefined)")); break; case -1: printf (_("(undefined)")); break;
@ -1998,7 +2005,7 @@ read_and_display_attr_value (unsigned long attribute,
if ((dwarf_version < 4 if ((dwarf_version < 4
&& (form == DW_FORM_data4 || form == DW_FORM_data8)) && (form == DW_FORM_data4 || form == DW_FORM_data8))
|| form == DW_FORM_sec_offset) || form == DW_FORM_sec_offset)
printf (_("(location list)")); printf (_(" (location list)"));
/* Fall through. */ /* Fall through. */
case DW_AT_allocated: case DW_AT_allocated:
case DW_AT_associated: case DW_AT_associated:
@ -2010,7 +2017,7 @@ read_and_display_attr_value (unsigned long attribute,
{ {
int need_frame_base; int need_frame_base;
printf ("("); printf ("\t(");
need_frame_base = decode_location_expression (block_start, need_frame_base = decode_location_expression (block_start,
pointer_size, pointer_size,
offset_size, offset_size,
@ -2046,7 +2053,7 @@ read_and_display_attr_value (unsigned long attribute,
abbrev_number = read_uleb128 (section->start + uvalue, NULL, end); abbrev_number = read_uleb128 (section->start + uvalue, NULL, end);
printf (_("[Abbrev Number: %ld"), abbrev_number); printf (_("\t[Abbrev Number: %ld"), abbrev_number);
/* Don't look up abbrev for DW_FORM_ref_addr, as it very often will /* Don't look up abbrev for DW_FORM_ref_addr, as it very often will
use different abbrev table, and we don't track .debug_info chunks use different abbrev table, and we don't track .debug_info chunks
yet. */ yet. */

View file

@ -1,3 +1,11 @@
2013-12-20 Nick Clifton <nickc@redhat.com>
PR binutils/16218
* binutils-all/dw2-1.W: Update expected objdump output.
* binutils-all/i386/compressed-1a.d: Likewise.
* binutils-all/objdump.W: Likewise.
* binutils-all/x86-64/compressed-1a.d: Likewise.
2013-12-19 H.J. Lu <hongjiu.lu@intel.com> 2013-12-19 H.J. Lu <hongjiu.lu@intel.com>
PR binutils/16317 PR binutils/16317

View file

@ -1,3 +1,10 @@
2013-12-20 Nick Clifton <nickc@redhat.com>
PR binutils/16218
* gas/elf/dwarf2-1.d: Update expected objdump output.
* gas/elf/dwarf2-2.d: Likewise.
* gas/i386/dw2-compress-1.d: Likewise.
2013-12-19 H.J. Lu <hongjiu.lu@intel.com> 2013-12-19 H.J. Lu <hongjiu.lu@intel.com>
* gas/i386/i386.exp: Don't run x86-64-disassem for mingw targets. * gas/i386/i386.exp: Don't run x86-64-disassem for mingw targets.