FreeChainXenon/binutils-gdb
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

bfd_set_input_error

Browse source 
A downside to the 2017-10-04 PR22245 fix is that bfd_set_error can now
silently accept invalid errors if/when someone passes the a value of
the wrong enumeration type, which previously would be caught by the
-Wenum-conversion warning.

	PR 22245
	* bfd.c (bfd_set_error): Revert 2017-10-04 change.  Remove
	ellipsis parameter.  Split out bfd_error_on_input code to..
	(bfd_set_input_error): .. New function.
	* archive.c (_bfd_write_archive_contents): Use bfd_set_input_error.
	* vms-lib.c (_bfd_vms_lib_write_archive_contents): Likewise.
	* bfd-in2.h: Regenerate.
This commit is contained in:
Pedro Alves 2017-10-04 14:20:51 +01:00 • committed by Alan Modra
parent 7d36e27991
commit 2ca7de3746
5 changed files with 47 additions and 20 deletions
Download patch file Download diff file Expand all files Collapse all files

2
bfd/vms-lib.c
View file

@ -2305,7 +2305,7 @@ _bfd_vms_lib_write_archive_contents (bfd *arch)
return TRUE;
input_err:
bfd_set_error (bfd_error_on_input, current, bfd_get_error ());
bfd_set_input_error (current, bfd_get_error ());
return FALSE;
}