FreeChainXenon/binutils-gdb
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Remove some unnecessary declarations and configury

Browse source 
configure checks for declarations of free, malloc, and realloc; but
the results are only used in a single spot: utils.c.  I think these
checks are long since obsolete, so this patch removes them.

Grepping the entire tree for these HAVE_DECL_ symbols, the only uses
of possible interest to gdb come from bfd/sysdep.h; but this is not
(nor should be) included by gdb.  (And furthermore I think the code
there is probably also obsolete.)

gdb/ChangeLog
2018-07-24  Tom Tromey  <tom@tromey.com>

	* utils.c (malloc, realloc, free): Don't declare.
	* configure, config.in: Rebuild.
	* configure.ac: Don't check for declarations of free, malloc, or
	realloc.
This commit is contained in:
Tom Tromey 2018-07-22 09:34:42 -06:00
parent 56522fc5af
commit 29d17e4773
5 changed files with 8 additions and 53 deletions
Download patch file Download diff file Expand all files Collapse all files

7
gdb/ChangeLog
View file

@ -1,3 +1,10 @@
2018-07-24 Tom Tromey <tom@tromey.com>
* utils.c (malloc, realloc, free): Don't declare.
* configure, config.in: Rebuild.
* configure.ac: Don't check for declarations of free, malloc, or
realloc.
2018-07-22 Simon Marchi <simon.marchi@polymtl.ca> 2018-07-22 Simon Marchi <simon.marchi@polymtl.ca>
* aarch64-linux-nat.c * aarch64-linux-nat.c

12
gdb/config.in
View file

@ -102,26 +102,14 @@
/* Define to 1 if you have the declaration of `ffs', and to 0 if you don't. */ /* Define to 1 if you have the declaration of `ffs', and to 0 if you don't. */
#undef HAVE_DECL_FFS #undef HAVE_DECL_FFS
/* Define to 1 if you have the declaration of `free', and to 0 if you don't.
*/
#undef HAVE_DECL_FREE
/* Define to 1 if you have the declaration of `getthrds', and to 0 if you /* Define to 1 if you have the declaration of `getthrds', and to 0 if you
don't. */ don't. */
#undef HAVE_DECL_GETTHRDS #undef HAVE_DECL_GETTHRDS
/* Define to 1 if you have the declaration of `malloc', and to 0 if you don't.
*/
#undef HAVE_DECL_MALLOC
/* Define to 1 if you have the declaration of `ptrace', and to 0 if you don't. /* Define to 1 if you have the declaration of `ptrace', and to 0 if you don't.
*/ */
#undef HAVE_DECL_PTRACE #undef HAVE_DECL_PTRACE
/* Define to 1 if you have the declaration of `realloc', and to 0 if you
don't. */
#undef HAVE_DECL_REALLOC
/* Define to 1 if you have the declaration of `snprintf', and to 0 if you /* Define to 1 if you have the declaration of `snprintf', and to 0 if you
don't. */ don't. */
#undef HAVE_DECL_SNPRINTF #undef HAVE_DECL_SNPRINTF

30
gdb/configure vendored
View file

@ -12394,36 +12394,6 @@ _ACEOF
ac_fn_c_check_decl "$LINENO" "free" "ac_cv_have_decl_free" "$ac_includes_default"
if test "x$ac_cv_have_decl_free" = xyes; then :
ac_have_decl=1
else
ac_have_decl=0
fi
cat >>confdefs.h <<_ACEOF
#define HAVE_DECL_FREE $ac_have_decl
_ACEOF
ac_fn_c_check_decl "$LINENO" "malloc" "ac_cv_have_decl_malloc" "$ac_includes_default"
if test "x$ac_cv_have_decl_malloc" = xyes; then :
ac_have_decl=1
else
ac_have_decl=0
fi
cat >>confdefs.h <<_ACEOF
#define HAVE_DECL_MALLOC $ac_have_decl
_ACEOF
ac_fn_c_check_decl "$LINENO" "realloc" "ac_cv_have_decl_realloc" "$ac_includes_default"
if test "x$ac_cv_have_decl_realloc" = xyes; then :
ac_have_decl=1
else
ac_have_decl=0
fi
cat >>confdefs.h <<_ACEOF
#define HAVE_DECL_REALLOC $ac_have_decl
_ACEOF
ac_fn_c_check_decl "$LINENO" "snprintf" "ac_cv_have_decl_snprintf" "$ac_includes_default" ac_fn_c_check_decl "$LINENO" "snprintf" "ac_cv_have_decl_snprintf" "$ac_includes_default"
if test "x$ac_cv_have_decl_snprintf" = xyes; then : if test "x$ac_cv_have_decl_snprintf" = xyes; then :
ac_have_decl=1 ac_have_decl=1

2
gdb/configure.ac
View file

@ -1317,7 +1317,7 @@ AC_CHECK_HEADERS(term.h, [], [],
libiberty_INIT libiberty_INIT
AC_CHECK_DECLS([free, malloc, realloc, snprintf]) AC_CHECK_DECLS([snprintf])
AM_LC_MESSAGES AM_LC_MESSAGES
# ----------------------- # # ----------------------- #

10
gdb/utils.c
View file

@ -72,16 +72,6 @@
#include <algorithm> #include <algorithm>
#include "common/pathstuff.h" #include "common/pathstuff.h"
#if !HAVE_DECL_MALLOC
extern PTR malloc (); /* ARI: PTR */
#endif
#if !HAVE_DECL_REALLOC
extern PTR realloc (); /* ARI: PTR */
#endif
#if !HAVE_DECL_FREE
extern void free ();
#endif
void (*deprecated_error_begin_hook) (void); void (*deprecated_error_begin_hook) (void);
/* Prototypes for local functions */ /* Prototypes for local functions */