FreeChainXenon/binutils-gdb
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Remove usage of find_thread when calling resume_status_pending_p

Browse source 
Replace with find_thread.  Instead of setting the flag in the callback,
make the callback return true/false, and check the result against NULL
in the caller.

gdb/gdbserver/ChangeLog:

	* linux-low.c (resume_status_pending_p): Return bool, remove
	flag_p argument.
	(linux_resume): Use find_thread.
This commit is contained in:
Simon Marchi 2017-11-19 22:23:26 -05:00 • committed by Simon Marchi
parent 5fdda39248
commit 25c28b4d15
2 changed files with 12 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
gdb/gdbserver/ChangeLog
View file

@ -1,3 +1,9 @@
2017-11-19 Simon Marchi <simon.marchi@ericsson.com>
* linux-low.c (resume_status_pending_p): Return bool, remove
flag_p argument.
(linux_resume): Use find_thread.
2017-11-19 Simon Marchi <simon.marchi@ericsson.com> 2017-11-19 Simon Marchi <simon.marchi@ericsson.com>
* linux-low.c (struct thread_resume_array): Remove. * linux-low.c (struct thread_resume_array): Remove.

16
gdb/gdbserver/linux-low.c
View file

@ -4684,20 +4684,17 @@ linux_set_resume_request (thread_info *thread, thread_resume *resume, size_t n)
/* find_inferior callback for linux_resume. /* find_inferior callback for linux_resume.
Set *FLAG_P if this lwp has an interesting status pending. */ Set *FLAG_P if this lwp has an interesting status pending. */
static int static bool
resume_status_pending_p (thread_info *thread, void *flag_p) resume_status_pending_p (thread_info *thread)
{ {
struct lwp_info *lwp = get_thread_lwp (thread); struct lwp_info *lwp = get_thread_lwp (thread);
/* LWPs which will not be resumed are not interesting, because /* LWPs which will not be resumed are not interesting, because
we might not wait for them next time through linux_wait. */ we might not wait for them next time through linux_wait. */
if (lwp->resume == NULL) if (lwp->resume == NULL)
return 0; return false;
if (thread_still_has_status_pending_p (thread)) return thread_still_has_status_pending_p (thread);
* (int *) flag_p = 1;
return 0;
} }
/* Return 1 if this lwp that GDB wants running is stopped at an /* Return 1 if this lwp that GDB wants running is stopped at an
@ -5092,7 +5089,6 @@ static void
linux_resume (struct thread_resume *resume_info, size_t n) linux_resume (struct thread_resume *resume_info, size_t n)
{ {
struct thread_info *need_step_over = NULL; struct thread_info *need_step_over = NULL;
int any_pending;
int leave_all_stopped; int leave_all_stopped;
if (debug_threads) if (debug_threads)
@ -5112,9 +5108,9 @@ linux_resume (struct thread_resume *resume_info, size_t n)
would otherwise be sent. In non-stop mode, we'll apply this would otherwise be sent. In non-stop mode, we'll apply this
logic to each thread individually. We consume all pending events logic to each thread individually. We consume all pending events
before considering to start a step-over (in all-stop). */ before considering to start a step-over (in all-stop). */
any_pending = 0; bool any_pending = false;
if (!non_stop) if (!non_stop)
find_inferior (&all_threads, resume_status_pending_p, &any_pending); any_pending = find_thread (resume_status_pending_p) != NULL;
/* If there is a thread which would otherwise be resumed, which is /* If there is a thread which would otherwise be resumed, which is
stopped at a breakpoint that needs stepping over, then don't stopped at a breakpoint that needs stepping over, then don't