FreeChainXenon/binutils-gdb
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

gdb: change thread_info::name to unique_xmalloc_ptr, add helper function

Browse source 
This started out as changing thread_info::name to a unique_xmalloc_ptr.
That showed that almost all users of that field had the same logic to
get a thread's name: use thread_info::name if non-nullptr, else ask the
target.  Factor out this logic in a new thread_name free function.  Make
the field private (rename to m_name) and add some accessors.

Change-Id: Iebdd95f4cd21fbefc505249bd1d05befc466a2fc
This commit is contained in:
Simon Marchi 2021-09-01 12:19:30 -04:00
parent 7ebaa5f782
commit 25558938d0
6 changed files with 57 additions and 30 deletions
Download patch file Download diff file Expand all files Collapse all files

9
gdb/python/py-infthread.c
View file

@ -66,14 +66,10 @@ static PyObject *
thpy_get_name (PyObject *self, void *ignore)
{
thread_object *thread_obj = (thread_object *) self;
const char *name;
THPY_REQUIRE_VALID (thread_obj);
name = thread_obj->thread->name;
if (name == NULL)
name = target_thread_name (thread_obj->thread);
const char *name = thread_name (thread_obj->thread);
if (name == NULL)
Py_RETURN_NONE;
@ -115,8 +111,7 @@ thpy_set_name (PyObject *self, PyObject *newvalue, void *ignore)
return -1;
}
xfree (thread_obj->thread->name);
thread_obj->thread->name = name.release ();
thread_obj->thread->set_name (std::move (name));
return 0;
}