FreeChainXenon/binutils-gdb
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix gdbserver <library-list> and its #FIXED version="1.0"

Browse source 
While reimplementing <library-list/> I found from expat-2.0.1-11.fc15.x86_64:

warning: while parsing target library list (at line 1): Required attribute "version" of <library-list-svr4> not specified

I believe the same bug has to apply for existing FSF gdbserver but I do not
have any <library-list/> platform to test it (I did not try to build MinGW).

features/library-list.dtd:
<!ATTLIST library-list  version CDATA   #FIXED  "1.0">

http://www.xml.com/pub/a/98/10/guide0.html?page=3 says:

	In this case, the attribute is not required, but if it occurs, it must
	have the specified value.

Which would suggest gdbserver is right but solib-target.c is wrong.  One could
also make gdbserver explicit for the version (if those 14 bytes are not of
a concern).

gdb/ChangeLog
2015-06-10  Jan Kratochvil  <jan.kratochvil@redhat.com>

	* solib-target.c (library_list_start_list): Do not dereference
	variable version in its initialization.  Make the VERSION check handle
	NULL.
	(library_list_attributes): Make "version" GDB_XML_AF_OPTIONAL.

gdb/gdbserver/ChangeLog
2015-06-10  Jan Kratochvil  <jan.kratochvil@redhat.com>

	* server.c (handle_qxfer_libraries): Set `version' attribute for
	<library-list>.
This commit is contained in:
Jan Kratochvil 2015-06-10 18:29:05 +02:00
parent 51aad7cc44
commit 24c05f4605
4 changed files with 25 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

2
gdb/gdbserver/server.c
View file

@ -1291,7 +1291,7 @@ handle_qxfer_libraries (const char *annex,
if (document == NULL)
return -1;
strcpy (document, "<library-list>\n");
strcpy (document, "<library-list version=\"1.0\">\n");
p = document + strlen (document);
for_each_inferior_with_data (&all_dlls, emit_dll_description, &p);