FreeChainXenon/binutils-gdb
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

change delegation for to_read_description

Browse source 
This switches to_read_description to the "new normal" delegation
scheme.  This one was a bit trickier than the other changes due to the
way that target_read_description handled delegation.  I examined all
the target implementations of to_read_description and changed the ones
returning NULL to instead delegate.

2014-02-19  Tom Tromey  <tromey@redhat.com>

	* arm-linux-nat.c (arm_linux_read_description): Delegate when
	needed.
	* corelow.c (core_read_description): Delegate when needed.
	* remote.c (remote_read_description): Delegate when needed.
	* target-delegates.c: Rebuild.
	* target.c (target_read_description): Rewrite.
	* target.h (struct target_ops) <to_read_description>: Update
	comment.  Use TARGET_DEFAULT_RETURN.
This commit is contained in:
Tom Tromey 2014-01-13 09:30:30 -07:00
parent e88ef65ce5
commit 2117c711ae
7 changed files with 47 additions and 25 deletions
Download patch file Download diff file Expand all files Collapse all files

15
gdb/target.c
View file

@ -748,7 +748,6 @@ update_current_target (void)
(int (*) (CORE_ADDR, gdb_byte *, int, int,
struct mem_attrib *, struct target_ops *))
nomemory);
current_target.to_read_description = NULL;
#undef de_fault
@ -2630,19 +2629,7 @@ target_mourn_inferior (void)
const struct target_desc *
target_read_description (struct target_ops *target)
{
struct target_ops *t;
for (t = target; t != NULL; t = t->beneath)
if (t->to_read_description != NULL)
{
const struct target_desc *tdesc;
tdesc = t->to_read_description (t);
if (tdesc)
return tdesc;
}
return NULL;
return target->to_read_description (target);
}
/* This implements a basic search of memory, reading target memory and