FreeChainXenon/binutils-gdb
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

expand_symtab_containing_pc: Renamed from find_pc_sect_symtab_via_partial.

Browse source 
This patch just renames one function.
Its only caller is in stack.c where we're printing a backtrace
with non-zero info_verbose and we want to make sure all the needed
symtabs are expanded before printing the backtrace
so that debug symbol reading messages don't pollute the backtrace.

I think the new name of the function makes clearer to the reader
what is going on.

gdb/ChangeLog:

	* symtab.c (expand_symtab_containing_pc): Renamed from
	find_pc_sect_symtab_via_partial.  All callers updated.
This commit is contained in:
Doug Evans 2014-11-15 08:05:22 -08:00
parent 1ada499f30
commit 2097ae2584
4 changed files with 18 additions and 14 deletions
Download patch file Download diff file Expand all files Collapse all files

5
gdb/ChangeLog
View file

@ -1,3 +1,8 @@
2014-11-15 Doug Evans <xdje42@gmail.com>
* symtab.c (expand_symtab_containing_pc): Renamed from
find_pc_sect_symtab_via_partial. All callers updated.
2014-11-15 Yao Qi <yao@codesourcery.com> 2014-11-15 Yao Qi <yao@codesourcery.com>
* go32-nat.c (go32_create_inferior): Add missing parenthesis. * go32-nat.c (go32_create_inferior): Add missing parenthesis.

2
gdb/stack.c
View file

@ -1776,7 +1776,7 @@ backtrace_command_1 (char *count_exp, int show_locals, int no_filters,
QUIT; QUIT;
pc = get_frame_address_in_block (fi); pc = get_frame_address_in_block (fi);
find_pc_sect_symtab_via_partial (pc, find_pc_mapped_section (pc)); expand_symtab_containing_pc (pc, find_pc_mapped_section (pc));
} }
} }

20
gdb/symtab.c
View file

@ -1045,8 +1045,10 @@ matching_obj_sections (struct obj_section *obj_first,
return 0; return 0;
} }
struct symtab * /* See symtab.h. */
find_pc_sect_symtab_via_partial (CORE_ADDR pc, struct obj_section *section)
void
expand_symtab_containing_pc (CORE_ADDR pc, struct obj_section *section)
{ {
struct objfile *objfile; struct objfile *objfile;
struct bound_minimal_symbol msymbol; struct bound_minimal_symbol msymbol;
@ -1061,20 +1063,18 @@ find_pc_sect_symtab_via_partial (CORE_ADDR pc, struct obj_section *section)
|| MSYMBOL_TYPE (msymbol.minsym) == mst_abs || MSYMBOL_TYPE (msymbol.minsym) == mst_abs
|| MSYMBOL_TYPE (msymbol.minsym) == mst_file_data || MSYMBOL_TYPE (msymbol.minsym) == mst_file_data
|| MSYMBOL_TYPE (msymbol.minsym) == mst_file_bss)) || MSYMBOL_TYPE (msymbol.minsym) == mst_file_bss))
return NULL; return;
ALL_OBJFILES (objfile) ALL_OBJFILES (objfile)
{ {
struct symtab *result = NULL; struct symtab *s = NULL;
if (objfile->sf) if (objfile->sf)
result = objfile->sf->qf->find_pc_sect_symtab (objfile, msymbol, s = objfile->sf->qf->find_pc_sect_symtab (objfile, msymbol,
pc, section, 0); pc, section, 0);
if (result) if (s != NULL)
return result; return;
} }
return NULL;
} }
/* Debug symbols usually don't have section information. We need to dig that /* Debug symbols usually don't have section information. We need to dig that

5
gdb/symtab.h
View file

@ -1163,10 +1163,9 @@ extern int find_pc_partial_function (CORE_ADDR, const char **, CORE_ADDR *,
extern void clear_pc_function_cache (void); extern void clear_pc_function_cache (void);
/* lookup partial symbol table by address and section. */ /* Expand symtab containing PC, SECTION if not already expanded. */
extern struct symtab *find_pc_sect_symtab_via_partial (CORE_ADDR, extern void expand_symtab_containing_pc (CORE_ADDR, struct obj_section *);
struct obj_section *);
/* lookup full symbol table by address. */ /* lookup full symbol table by address. */