FreeChainXenon/binutils-gdb
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

gdb: add obj_section function to bound_minimal_symbol

Browse source 
Add a new obj_section function to bound_minimal_symbol, this just
calls obj_section on the contained minimal_symbol passing in the
contained objfile.

This allows some minor code simplification in a few places.

There should be no user visible changes after this commit.

gdb/ChangeLog:

	* breakpoint.c (resolve_sal_pc): Make use of
	bound_minimal_symbol::obj_section.
	* maint.c (maintenance_translate_address): Likewise.
	* minsyms.c (minimal_symbol_upper_bound): Likewise.
	* minsyms.h (struct bound_minimal_symbol) <obj_section>: New
	member function.
	* printcmd.c (info_address_command): Make use of
	bound_minimal_symbol::obj_section.
This commit is contained in:
Andrew Burgess 2021-02-10 15:07:04 +00:00
parent 31c711a2b3
commit 1db66e348a
6 changed files with 22 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

11
gdb/ChangeLog
View file

@ -1,3 +1,14 @@
2021-02-11 Andrew Burgess <andrew.burgess@embecosm.com>
* breakpoint.c (resolve_sal_pc): Make use of
bound_minimal_symbol::obj_section.
* maint.c (maintenance_translate_address): Likewise.
* minsyms.c (minimal_symbol_upper_bound): Likewise.
* minsyms.h (struct bound_minimal_symbol) <obj_section>: New
member function.
* printcmd.c (info_address_command): Make use of
bound_minimal_symbol::obj_section.
2021-02-11 Alan Modra <amodra@gmail.com> 2021-02-11 Alan Modra <amodra@gmail.com>
* arm-symbian-tdep.c: Delete. * arm-symbian-tdep.c: Delete.

2
gdb/breakpoint.c
View file

@ -9691,7 +9691,7 @@ resolve_sal_pc (struct symtab_and_line *sal)
bound_minimal_symbol msym = lookup_minimal_symbol_by_pc (sal->pc); bound_minimal_symbol msym = lookup_minimal_symbol_by_pc (sal->pc);
if (msym.minsym) if (msym.minsym)
sal->section = msym.minsym->obj_section (msym.objfile); sal->section = msym.obj_section ();
} }
} }
} }

2
gdb/maint.c
View file

@ -509,7 +509,7 @@ maintenance_translate_address (const char *arg, int from_tty)
const char *symbol_offset const char *symbol_offset
= pulongest (address - BMSYMBOL_VALUE_ADDRESS (sym)); = pulongest (address - BMSYMBOL_VALUE_ADDRESS (sym));
sect = sym.minsym->obj_section (sym.objfile); sect = sym.obj_section ();
if (sect != NULL) if (sect != NULL)
{ {
const char *section_name; const char *section_name;

2
gdb/minsyms.c
View file

@ -1561,7 +1561,7 @@ minimal_symbol_upper_bound (struct bound_minimal_symbol minsym)
break; break;
} }
obj_section = minsym.minsym->obj_section (minsym.objfile); obj_section = minsym.obj_section ();
if (iter != past_the_end if (iter != past_the_end
&& (MSYMBOL_VALUE_ADDRESS (minsym.objfile, iter) && (MSYMBOL_VALUE_ADDRESS (minsym.objfile, iter)
< obj_section_endaddr (obj_section))) < obj_section_endaddr (obj_section)))

7
gdb/minsyms.h
View file

@ -37,6 +37,13 @@ struct bound_minimal_symbol
symbol is defined. */ symbol is defined. */
struct objfile *objfile; struct objfile *objfile;
/* Return the obj_section from OBJFILE for MINSYM. */
struct obj_section *obj_section () const
{
return minsym->obj_section (objfile);
}
}; };
/* This header declares most of the API for dealing with minimal /* This header declares most of the API for dealing with minimal

2
gdb/printcmd.c
View file

@ -1678,7 +1678,7 @@ info_address_command (const char *exp, int from_tty)
printf_filtered ("unresolved"); printf_filtered ("unresolved");
else else
{ {
section = msym.minsym->obj_section (msym.objfile); section = msym.obj_section ();
if (section if (section
&& (section->the_bfd_section->flags & SEC_THREAD_LOCAL) != 0) && (section->the_bfd_section->flags & SEC_THREAD_LOCAL) != 0)