Remove stale inline function handling from selftest_setup
Before commit70ee000084
("[gdb] Allow function arguments in bp print match in selftest_setup"), this pattern in selftest_setup: -re "Starting program.*Breakpoint \[0-9\]+,.* at .*main.c:.*$function.*$gdb_prompt $" { # $function may be inlined, so the program stops at the line # calling $function. pass "$description" } happened to match if captured_main_1 was inlined and captured_main was not, because captured_main calls captured_main_1 first thing, which coincidentally matches "$function.*": Breakpoint 1, captured_main (data=<optimized out>) at src/gdb/main.c:1147 1147 captured_main_1 (context); That would probably be better "$function .*", with a space, but I think that even better is to remove the "may be inlined" case too now, because sinceddfe970e6b
("Don't elide all inlined frames") GDB presents the stop at the inline function instead of at the caller. gdb/testsuite/ChangeLog: 2018-06-14 Pedro Alves <palves@redhat.com> * lib/selftest-support.exp (selftest_setup): Remove inlined function handling.
This commit is contained in:
parent
70ee000084
commit
1d39de443a
2 changed files with 5 additions and 5 deletions
|
@ -1,3 +1,8 @@
|
|||
2018-06-14 Pedro Alves <palves@redhat.com>
|
||||
|
||||
* lib/selftest-support.exp (selftest_setup): Remove inlined
|
||||
function handling.
|
||||
|
||||
2018-06-14 Tom de Vries <tdevries@suse.de>
|
||||
|
||||
* lib/selftest-support.exp (selftest_setup): Allow function arguments in
|
||||
|
|
|
@ -94,11 +94,6 @@ proc selftest_setup { executable function } {
|
|||
-re "Starting program.*Breakpoint \[0-9\]+,.*$function \\(.*\\).*$gdb_prompt $" {
|
||||
xfail "$description (line numbers scrambled?)"
|
||||
}
|
||||
-re "Starting program.*Breakpoint \[0-9\]+,.* at .*main.c:.*$function.*$gdb_prompt $" {
|
||||
# $function may be inlined, so the program stops at the line
|
||||
# calling $function.
|
||||
pass "$description"
|
||||
}
|
||||
-re "vfork: No more processes.*$gdb_prompt $" {
|
||||
fail "$description (out of virtual memory)"
|
||||
set timeout $oldtimeout
|
||||
|
|
Loading…
Add table
Reference in a new issue