FreeChainXenon/binutils-gdb
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Remove some cleanups from solib.c

Browse source 
This removes some cleanups from solib.c, replacing them with
gdb::def_vector.

Regression tested by the buildbot.

gdb/ChangeLog
2018-03-18  Tom Tromey  <tom@tromey.com>

	* solib.c (gdb_bfd_lookup_symbol_from_symtab): Use
	gdb::def_vector.
	(bfd_lookup_symbol_from_dyn_symtab): Likewise.
This commit is contained in:
Tom Tromey 2017-11-10 13:48:48 -07:00
parent c820f6a44d
commit 1cb1f3dae7
2 changed files with 10 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

6
gdb/ChangeLog
View file

@ -1,3 +1,9 @@
2018-03-18 Tom Tromey <tom@tromey.com>
* solib.c (gdb_bfd_lookup_symbol_from_symtab): Use
gdb::def_vector.
(bfd_lookup_symbol_from_dyn_symtab): Likewise.
2018-03-17 Tom Tromey <tom@tromey.com> 2018-03-17 Tom Tromey <tom@tromey.com>
* auto-load.c (auto_load_objfile_script_1): Use std::string. * auto-load.c (auto_load_objfile_script_1): Use std::string.

10
gdb/solib.c
View file

@ -1474,8 +1474,8 @@ gdb_bfd_lookup_symbol_from_symtab (bfd *abfd,
{ {
unsigned int i; unsigned int i;
asymbol **symbol_table = (asymbol **) xmalloc (storage_needed); gdb::def_vector<asymbol *> storage (storage_needed / sizeof (asymbol *));
struct cleanup *back_to = make_cleanup (xfree, symbol_table); asymbol **symbol_table = storage.data ();
unsigned int number_of_symbols = unsigned int number_of_symbols =
bfd_canonicalize_symtab (abfd, symbol_table); bfd_canonicalize_symtab (abfd, symbol_table);
@ -1510,7 +1510,6 @@ gdb_bfd_lookup_symbol_from_symtab (bfd *abfd,
break; break;
} }
} }
do_cleanups (back_to);
} }
return symaddr; return symaddr;
@ -1533,8 +1532,8 @@ bfd_lookup_symbol_from_dyn_symtab (bfd *abfd,
if (storage_needed > 0) if (storage_needed > 0)
{ {
unsigned int i; unsigned int i;
asymbol **symbol_table = (asymbol **) xmalloc (storage_needed); gdb::def_vector<asymbol *> storage (storage_needed / sizeof (asymbol *));
struct cleanup *back_to = make_cleanup (xfree, symbol_table); asymbol **symbol_table = storage.data ();
unsigned int number_of_symbols = unsigned int number_of_symbols =
bfd_canonicalize_dynamic_symtab (abfd, symbol_table); bfd_canonicalize_dynamic_symtab (abfd, symbol_table);
@ -1549,7 +1548,6 @@ bfd_lookup_symbol_from_dyn_symtab (bfd *abfd,
break; break;
} }
} }
do_cleanups (back_to);
} }
return symaddr; return symaddr;
} }