FreeChainXenon/binutils-gdb
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Preserve sign when converting gdb.Value to Python int

Browse source 
PR python/20126 points out that sometimes the conversion of a
gdb.Value can result in a negative Python integer.  This happens
because valpy_int does not examine the signedness of the value's type.

gdb/ChangeLog
2018-09-23  Tom Tromey  <tom@tromey.com>

	PR python/20126:
	* python/py-value.c (valpy_int): Respect type sign.

gdb/testsuite/ChangeLog
2018-09-23  Tom Tromey  <tom@tromey.com>

	PR python/20126:
	* gdb.python/py-value.exp (test_value_numeric_ops): Add
	signed-ness conversion tests.
This commit is contained in:
Tom Tromey 2018-09-14 22:44:10 -06:00
parent fb4fa9469c
commit 1c1e54f6b4
4 changed files with 23 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

5
gdb/python/py-value.c
View file

@ -1514,7 +1514,10 @@ valpy_int (PyObject *self)
}
END_CATCH
return gdb_py_object_from_longest (l);
if (TYPE_UNSIGNED (type))
return gdb_py_object_from_ulongest (l);
else
return gdb_py_object_from_longest (l);
}
#endif