FreeChainXenon/binutils-gdb
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

* breakpoint.c (bpstat_free): New.

Browse source 
(bpstat_clear): Use bpstat_free.
	(delete_breakpoint): Document why we cannot
	remove bpstats from stop_bpstat.
	* breakpoint.h (bpstat_free): Declare.
This commit is contained in:
Vladimir Prus 2007-08-17 17:06:04 +00:00
parent 3992d3b7e2
commit 198757a8b1
3 changed files with 31 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
gdb/ChangeLog
View file

@ -1,3 +1,11 @@
2007-08-17 Vladimir Prus <vladimir@codesourcery.com>
* breakpoint.c (bpstat_free): New.
(bpstat_clear): Use bpstat_free.
(delete_breakpoint): Document why we cannot
remove bpstats from stop_bpstat.
* breakpoint.h (bpstat_free): Declare.
2007-08-16 Michael Snyder <msnyder@access-company.com>
* event-loop.c (gdb_wait_for_event): Move statement into "if" block.

22
gdb/breakpoint.c
View file

@ -1897,6 +1897,15 @@ ep_is_exception_catchpoint (struct breakpoint *ep)
|| (ep->type == bp_catch_throw);
}
void
bpstat_free (bpstat bs)
{
if (bs->old_val != NULL)
value_free (bs->old_val);
free_command_lines (&bs->commands);
xfree (bs);
}
/* Clear a bpstat so that it says we are not at any breakpoint.
Also free any storage that is part of a bpstat. */
@ -1912,10 +1921,7 @@ bpstat_clear (bpstat *bsp)
while (p != NULL)
{
q = p->next;
if (p->old_val != NULL)
value_free (p->old_val);
free_command_lines (&p->commands);
xfree (p);
bpstat_free (p);
p = q;
}
*bsp = NULL;
@ -7051,7 +7057,13 @@ delete_breakpoint (struct breakpoint *bpt)
/* Be sure no bpstat's are pointing at it after it's been freed. */
/* FIXME, how can we find all bpstat's?
We just check stop_bpstat for now. */
We just check stop_bpstat for now. Note that we cannot just
remove bpstats pointing at bpt from the stop_bpstat list
entirely, as breakpoint commands are associated with the bpstat;
if we remove it here, then the later call to
bpstat_do_actions (&stop_bpstat);
in event-top.c won't do anything, and temporary breakpoints
with commands won't work. */
for (bs = stop_bpstat; bs; bs = bs->next)
if (bs->breakpoint_at == bpt)
{

9
gdb/breakpoint.h
View file

@ -430,9 +430,12 @@ struct breakpoint
typedef struct bpstats *bpstat;
/* Interface: */
/* Clear a bpstat so that it says we are not at any breakpoint.
Also free any storage that is part of a bpstat. */
/* Frees any storage that is part of a bpstat.
Does not walk the 'next' chain. */
extern void bpstat_free (bpstat);
/* Clears a chain of bpstat, freeing storage
of each. */
extern void bpstat_clear (bpstat *);
/* Return a copy of a bpstat. Like "bs1 = bs2" but all storage that