FreeChainXenon/binutils-gdb
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

gdb: more filename styling

Browse source 
I spotted a few places in solib.c and build-id.c where we could apply
file name styling.

Other than the extra styling, there should be no user visible changes
after this commit.

Approved-By: Tom Tromey <tom@tromey.com>
This commit is contained in:
Andrew Burgess 2024-04-30 15:47:41 +01:00
parent 0fd705062e
commit 189d3013ee
2 changed files with 16 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
gdb/build-id.c
View file

@ -60,12 +60,14 @@ build_id_verify (bfd *abfd, size_t check_len, const bfd_byte *check)
found = build_id_bfd_get (abfd);
if (found == NULL)
warning (_("File \"%s\" has no build-id, file skipped"),
bfd_get_filename (abfd));
warning (_("File \"%ps\" has no build-id, file skipped"),
styled_string (file_name_style.style (),
bfd_get_filename (abfd)));
else if (found->size != check_len
|| memcmp (found->data, check, found->size) != 0)
warning (_("File \"%s\" has a different build-id, file skipped"),
bfd_get_filename (abfd));
warning (_("File \"%ps\" has a different build-id, file skipped"),
styled_string (file_name_style.style (),
bfd_get_filename (abfd)));
else
retval = 1;

16
gdb/solib.c
View file

@ -903,16 +903,19 @@ update_solib_list (int from_tty)
stand out well. */
if (not_found == 1)
warning (_ ("Could not load shared library symbols for %s.\n"
warning (_ ("Could not load shared library symbols for %ps.\n"
"Do you need \"set solib-search-path\" "
"or \"set sysroot\"?"),
not_found_filename);
styled_string (file_name_style.style (),
not_found_filename));
else if (not_found > 1)
warning (_ ("\
Could not load shared library symbols for %d libraries, e.g. %s.\n\
Could not load shared library symbols for %d libraries, e.g. %ps.\n\
Use the \"info sharedlibrary\" command to see the complete listing.\n\
Do you need \"set solib-search-path\" or \"set sysroot\"?"),
not_found, not_found_filename);
not_found,
styled_string (file_name_style.style (),
not_found_filename));
}
}
@ -1005,8 +1008,9 @@ solib_add (const char *pattern, int from_tty, int readsyms)
/* If no pattern was given, be quiet for shared
libraries we have already loaded. */
if (pattern && (from_tty || info_verbose))
gdb_printf (_ ("Symbols already loaded for %s\n"),
gdb.so_name.c_str ());
gdb_printf (_ ("Symbols already loaded for %ps\n"),
styled_string (file_name_style.style (),
gdb.so_name.c_str ()));
}
else if (solib_read_symbols (gdb, add_flags))
loaded_any_symbols = true;