FreeChainXenon/binutils-gdb
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

gdb: move baud_rate and serial_parity declarations to serial.h

Browse source 
They are currently in target.h, it would make more sense to have them in
serial.h, since they are defined in serial.c.

gdb/ChangeLog:

	* target.h (baud_rate, serial_parity): Move declarations...
	* serial.h: ... here.
	* main.c: Include serial.h.
	* serial.c (baud_rate, serial_parity): Update doc.

Change-Id: Idc983c154c80ccc29b07ce68df3483cefe03fb71
This commit is contained in:
Simon Marchi 2021-01-12 14:19:49 -05:00
parent 3f94e58859
commit 16e9019ef7
5 changed files with 18 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
gdb/ChangeLog
View file

@ -1,3 +1,10 @@
2021-01-12 Simon Marchi <simon.marchi@polymtl.ca>
* target.h (baud_rate, serial_parity): Move declarations...
* serial.h: ... here.
* main.c: Include serial.h.
* serial.c (baud_rate, serial_parity): Update doc.
2021-01-12 Simon Marchi <simon.marchi@polymtl.ca>
* top.c (pre_init_ui_hook): Remove.

1
gdb/main.c
View file

@ -54,6 +54,7 @@
#endif
#include "gdbsupport/alt-stack.h"
#include "observable.h"
#include "serial.h"
/* The selected interpreter. This will be used as a set command
variable, so it should always be malloc'ed - since

7
gdb/serial.c
View file

@ -623,10 +623,7 @@ serial_pipe (struct serial *scbs[2])
static struct cmd_list_element *serial_set_cmdlist;
static struct cmd_list_element *serial_show_cmdlist;
/* Baud rate specified for talking to serial target systems. Default
is left as -1, so targets can choose their own defaults. */
/* FIXME: This means that "show serial baud" and gr_files_info can
print -1 or (unsigned int)-1. This is a Bad User Interface. */
/* See serial.h. */
int baud_rate = -1;
@ -638,7 +635,7 @@ serial_baud_show_cmd (struct ui_file *file, int from_tty,
value);
}
/* Parity for serial port. */
/* See serial.h. */
int serial_parity = GDBPARITY_NONE;

8
gdb/serial.h
View file

@ -36,6 +36,14 @@ typedef void *serial_ttystate;
struct serial;
struct serial_ops;
/* Speed in bits per second, or -1 which means don't mess with the speed. */
extern int baud_rate;
/* Parity for serial port */
extern int serial_parity;
/* Create a new serial for OPS. The new serial is not opened. */
/* Try to open NAME. Returns a new `struct serial *' on success, NULL

6
gdb/target.h
View file

@ -2477,12 +2477,6 @@ extern gdb::optional<gdb::char_vector> target_get_osdata (const char *type);
information (higher values, more information). */
extern int remote_debug;
/* Speed in bits per second, or -1 which means don't mess with the speed. */
extern int baud_rate;
/* Parity for serial port */
extern int serial_parity;
/* Timeout limit for response from target. */
extern int remote_timeout;