FreeChainXenon/binutils-gdb
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

MIPS: don't use get_symbol_name() for section parsing. With s_change_section() later calling obj_elf_section(), it seems better to pre-parse the section name by the same function that will be used there. This way no differences in what is accepted will result.

Browse source 
gas	* config/tc-mips.c (s_change_section): Use obj_elf_section_name to
	parse the section name.
This commit is contained in:
Jan Beulich 2021-09-13 11:02:48 +01:00 • committed by Nick Clifton
parent 5a2947cf17
commit 168495916d
2 changed files with 8 additions and 14 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
gas/ChangeLog
View file

@ -2,6 +2,7 @@
* config/tc-ia64.c (cross_section): Use obj_elf_section_name to
parse the section name.
* config/tc-mips.c (s_change_section): Likewise.
2021-09-02 Nick Clifton <nickc@redhat.com>

21
gas/config/tc-mips.c
View file

@ -16371,33 +16371,29 @@ void
s_change_section (int ignore ATTRIBUTE_UNUSED)
{
char *saved_ilp;
char *section_name;
char c, endc;
char next_c = 0;
const char *section_name;
char c, next_c = 0;
int section_type;
int section_flag;
int section_entry_size;
int section_alignment;
saved_ilp = input_line_pointer;
endc = get_symbol_name (&section_name);
c = (endc == '"' ? input_line_pointer[1] : endc);
section_name = obj_elf_section_name ();
if (section_name == NULL)
return;
c = input_line_pointer[0];
if (c)
next_c = input_line_pointer [(endc == '"' ? 2 : 1)];
next_c = input_line_pointer[1];
/* Do we have .section Name<,"flags">? */
if (c != ',' || (c == ',' && next_c == '"'))
{
/* Just after name is now '\0'. */
(void) restore_line_pointer (endc);
input_line_pointer = saved_ilp;
obj_elf_section (ignore);
return;
}
section_name = xstrdup (section_name);
c = restore_line_pointer (endc);
input_line_pointer++;
/* Do we have .section Name<,type><,flag><,entry_size><,alignment> */
@ -16442,9 +16438,6 @@ s_change_section (int ignore ATTRIBUTE_UNUSED)
obj_elf_change_section (section_name, section_type, section_flag,
section_entry_size, 0, 0, 0);
if (now_seg->name != section_name)
free (section_name);
}
void