FreeChainXenon/binutils-gdb
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Change gdbscm_exception_message_to_string to return a unique_xmalloc_ptr

Browse source 
This changes gdbscm_exception_message_to_string to return a
unique_xmalloc_ptr, allowing for the removal of some cleanups.
unique_xmalloc_ptr was chosen because at the root of the call chains
is a function from Guile that returns a malloc'd string.

gdb/ChangeLog
2018-07-17  Tom Tromey  <tom@tromey.com>

	* guile/scm-param.c (pascm_signal_setshow_error): Update.
	* guile/guile-internal.h (gdbscm_exception_message_to_string):
	Update.
	* guile/scm-cmd.c (cmdscm_function): Update.
	* guile/scm-pretty-print.c
	(ppscm_print_exception_unless_memory_error): Update.
	* guile/scm-exception.c (gdbscm_exception_message_to_string):
	Return unique_xmalloc_ptr.
This commit is contained in:
Tom Tromey 2018-05-26 23:21:23 -06:00
parent 7eb1a66c26
commit 15bf30027b
6 changed files with 31 additions and 23 deletions
Download patch file Download diff file Expand all files Collapse all files

6
gdb/guile/scm-cmd.c
View file

@ -316,10 +316,10 @@ cmdscm_function (struct cmd_list_element *command,
itself. */
if (gdbscm_user_error_p (gdbscm_exception_key (result)))
{
char *msg = gdbscm_exception_message_to_string (result);
gdb::unique_xmalloc_ptr<char> msg
= gdbscm_exception_message_to_string (result);
make_cleanup (xfree, msg);
error ("%s", msg);
error ("%s", msg.get ());
}
else
{