FreeChainXenon/binutils-gdb
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Clear HAS_RELOC if there are no relocations

Browse source 
The HAS_RELOC bit should be cleared when relocations are removed from
relocatable files.

bfd/

	PR binutils/19547
	* elf.c (assign_section_numbers): Clear HAS_RELOC if there are
	no relocations in relocatable files.

binutils/

	PR binutils/19547
	* testsuite/binutils-all/objcopy.exp
	(objcopy_test_without_global_symbol): New proc.
	Run objcopy_test_without_global_symbol.
	* testsuite/binutils-all/pr19547.c: New file.
This commit is contained in:
H.J. Lu 2016-02-02 03:30:21 -08:00
parent a143b0045c
commit 14f2c699dd
5 changed files with 64 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

6
bfd/ChangeLog
View file

@ -1,3 +1,9 @@
2016-02-02 H.J. Lu <hongjiu.lu@intel.com>
PR binutils/19547
* elf.c (assign_section_numbers): Clear HAS_RELOC if there are
no relocations in relocatable files.
2016-02-01 H.J. Lu <hongjiu.lu@intel.com> 2016-02-01 H.J. Lu <hongjiu.lu@intel.com>
PR ld/19553 PR ld/19553

9
bfd/elf.c
View file

@ -3355,6 +3355,8 @@ assign_section_numbers (bfd *abfd, struct bfd_link_info *link_info)
/* SHT_GROUP sections are in relocatable files only. */ /* SHT_GROUP sections are in relocatable files only. */
if (link_info == NULL || bfd_link_relocatable (link_info)) if (link_info == NULL || bfd_link_relocatable (link_info))
{ {
bfd_size_type reloc_count = 0;
/* Put SHT_GROUP sections first. */ /* Put SHT_GROUP sections first. */
for (sec = abfd->sections; sec != NULL; sec = sec->next) for (sec = abfd->sections; sec != NULL; sec = sec->next)
{ {
@ -3371,7 +3373,14 @@ assign_section_numbers (bfd *abfd, struct bfd_link_info *link_info)
else else
d->this_idx = section_number++; d->this_idx = section_number++;
} }
/* Count relocations. */
reloc_count += sec->reloc_count;
} }
/* Clear HAS_RELOC if there are no relocations. */
if (reloc_count == 0)
abfd->flags &= ~HAS_RELOC;
} }
for (sec = abfd->sections; sec; sec = sec->next) for (sec = abfd->sections; sec; sec = sec->next)

8
binutils/ChangeLog
View file

@ -1,3 +1,11 @@
2016-02-02 H.J. Lu <hongjiu.lu@intel.com>
PR binutils/19547
* testsuite/binutils-all/objcopy.exp
(objcopy_test_without_global_symbol): New proc.
Run objcopy_test_without_global_symbol.
* testsuite/binutils-all/pr19547.c: New file.
2016-01-28 H.J. Lu <hongjiu.lu@intel.com> 2016-01-28 H.J. Lu <hongjiu.lu@intel.com>
PR binutils/19523 PR binutils/19523

40
binutils/testsuite/binutils-all/objcopy.exp
View file

@ -1104,3 +1104,43 @@ if [is_elf_format] {
run_dump_test "exclude-1b" run_dump_test "exclude-1b"
} }
run_dump_test "localize-hidden-2" run_dump_test "localize-hidden-2"
# Test objcopying an object file without global symbol
proc objcopy_test_without_global_symbol { } {
global OBJCOPY
global OBJCOPYFLAGS
global OBJDUMP
global OBJDUMPFLAGS
global srcdir
global subdir
set test "strip without global symbol "
if { [target_compile $srcdir/$subdir/pr19547.c tmpdir/pr19547.o object debug] != "" } {
untested $test
return
}
if [is_remote host] {
set objfile [remote_download host tmpdir/pr19547.o]
} else {
set objfile tmpdir/pr19547.o
}
set exec_output [binutils_run $OBJCOPY "$OBJCOPYFLAGS --strip-unneeded $objfile"]
if ![string equal "" $exec_output] {
fail $test
return
}
set exec_output [binutils_run $OBJDUMP "$OBJDUMPFLAGS -t $objfile"]
if {![regexp "no symbols" $exec_output]} {
fail $test
return
}
pass $test
}
objcopy_test_without_global_symbol

1
binutils/testsuite/binutils-all/pr19547.c Normal file
View file

@ -0,0 +1 @@
static char foo[]__attribute__ ((used)) = "foo";