FreeChainXenon/binutils-gdb
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Implement DAP register scope

Browse source 
I noticed that gdb's DAP code did not provide a way to see register
values.  DAP defines a "register" scope, which this patch implements.
This patch also adds the missing (and optional) "presentationHint" to
scopes.
This commit is contained in:
Tom Tromey 2023-04-13 11:24:02 -06:00
parent 61f9fb1ea4
commit 14e8fded85
2 changed files with 33 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

20
gdb/python/lib/gdb/dap/scopes.py
View file

@ -50,14 +50,16 @@ def _block_vars(block):
class ScopeReference(BaseReference):
def __init__(self, name, frame, var_list):
def __init__(self, name, hint, frame, var_list):
super().__init__(name)
self.hint = hint
self.frame = frame
self.func = frame.function()
self.var_list = var_list
def to_object(self):
result = super().to_object()
result["presentationHint"] = self.hint
# How would we know?
result["expensive"] = False
result["namedVariables"] = len(self.var_list)
@ -79,6 +81,17 @@ class ScopeReference(BaseReference):
return (sym.print_name, val)
class RegisterReference(ScopeReference):
def __init__(self, name, frame):
super().__init__(
name, "registers", frame, list(frame.architecture().registers())
)
@in_gdb_thread
def fetch_one_child(self, idx):
return (self.var_list[idx].name, self.frame.read_register(self.var_list[idx]))
# Helper function to create a DAP scopes for a given frame ID.
@in_gdb_thread
def _get_scope(id):
@ -88,9 +101,10 @@ def _get_scope(id):
if block is not None:
(args, locs) = _block_vars(block)
if args:
scopes.append(ScopeReference("Arguments", frame, args))
scopes.append(ScopeReference("Arguments", "arguments", frame, args))
if locs:
scopes.append(ScopeReference("Locals", frame, locs))
scopes.append(ScopeReference("Locals", "locals", frame, locs))
scopes.append(RegisterReference("Registers", frame))
return [x.to_object() for x in scopes]