FreeChainXenon/binutils-gdb
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

gdb: remove unnecessary cmd_list_element::aliases nullptr checks

Browse source 
Remove two unnecessary nullptr checks.  If aliases is nullptr, then the
for loops will simply be skipped.

Change-Id: I9132063bb17798391f8d019af305383fa8e0229f
This commit is contained in:
Simon Marchi 2021-10-31 10:58:47 -04:00
parent 6c130ba387
commit 143f5a3837
1 changed files with 11 additions and 17 deletions
Download patch file Download diff file Expand all files Collapse all files

12
gdb/cli/cli-decode.c
View file

@ -1351,16 +1351,11 @@ static void
fput_aliases_definition_styled (struct cmd_list_element *cmd, fput_aliases_definition_styled (struct cmd_list_element *cmd,
struct ui_file *stream) struct ui_file *stream)
{ {
if (cmd->aliases != nullptr)
{
for (cmd_list_element *iter = cmd->aliases; for (cmd_list_element *iter = cmd->aliases;
iter; iter != nullptr;
iter = iter->alias_chain) iter = iter->alias_chain)
{
if (!iter->default_args.empty ()) if (!iter->default_args.empty ())
fput_alias_definition_styled (iter, stream); fput_alias_definition_styled (iter, stream);
}
}
} }
@ -1377,15 +1372,14 @@ fput_command_names_styled (struct cmd_list_element *c,
{ {
if (always_fput_c_name || c->aliases != nullptr) if (always_fput_c_name || c->aliases != nullptr)
fput_command_name_styled (c, stream); fput_command_name_styled (c, stream);
if (c->aliases != nullptr)
{
for (cmd_list_element *iter = c->aliases; iter; iter = iter->alias_chain) for (cmd_list_element *iter = c->aliases; iter; iter = iter->alias_chain)
{ {
fputs_filtered (", ", stream); fputs_filtered (", ", stream);
wrap_here (" "); wrap_here (" ");
fput_command_name_styled (iter, stream); fput_command_name_styled (iter, stream);
} }
}
if (always_fput_c_name || c->aliases != nullptr) if (always_fput_c_name || c->aliases != nullptr)
fputs_filtered (postfix, stream); fputs_filtered (postfix, stream);
} }