FreeChainXenon/binutils-gdb
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

gdb: move compunit_filetabs to compunit_symtab::filetabs

Browse source 
Make compunit_filetabs, used to iterate a compunit_symtab's filetabs, a
method of compunit_symtab.  The name filetabs conflicts with the current
name of the field.  Rename the field to m_filetabs, since at this point
nothing outside of compunit_symtab uses it, so we should treat it as
private (even though it's not actually private).  Rename the
last_filetab field to m_last_filetab as well (it's only used on
compunit_symtab::add_filetab).

Adjust the COMPUNIT_FILETABS macro to keep its current behavior of
returning the first filetab.

Change-Id: I537b553a44451c52d24b18ee1bfa47e23747cfc3
This commit is contained in:
Simon Marchi 2021-11-19 21:18:05 -05:00 • committed by Simon Marchi
parent 36664835fa
commit 102cc23543
7 changed files with 39 additions and 41 deletions
Download patch file Download diff file Expand all files Collapse all files

4
gdb/source.c
View file

@ -344,7 +344,7 @@ select_source_symtab (struct symtab *s)
{
for (compunit_symtab *cu : ofp->compunits ())
{
for (symtab *symtab : compunit_filetabs (cu))
for (symtab *symtab : cu->filetabs ())
{
const char *name = symtab->filename;
int len = strlen (name);
@ -424,7 +424,7 @@ forget_cached_source_info_for_objfile (struct objfile *objfile)
{
for (compunit_symtab *cu : objfile->compunits ())
{
for (symtab *s : compunit_filetabs (cu))
for (symtab *s : cu->filetabs ())
{
if (s->fullname != NULL)
{