Mark move constructors as "noexcept"
I recently learned that move constructors generally should be marked "noexcept". This ensures that standard containers will move objects when possible, rather than copy them. This patch fixes the cases I could find. Note that implicitly-defined or defaulted move constructors will automatically do what you'd expect; that is, they are noexcept if all the members have noexcept move constructors. While doing this, I noticed a couple of odd cases where the move constructor seemed to assume that the object being constructed could have state requiring destruction. I've fixed these as well. See completion_result and scoped_mmap. gdb/ChangeLog 2020-04-20 Tom Tromey <tromey@adacore.com> * python/python.c (struct gdbpy_event): Mark move constructor as noexcept. * python/py-tui.c (class gdbpy_tui_window_maker): Mark move constructor as noexcept. * completer.h (struct completion_result): Mark move constructor as noexcept. * completer.c (completion_result::completion_result): Use initialization style. Don't call reset_match_list. gdbsupport/ChangeLog 2020-04-20 Tom Tromey <tromey@adacore.com> * scoped_mmap.h (scoped_mmap): Mark move constructor as noexcept. Use initialization style. Don't call destroy. * scoped_fd.h (class scoped_fd): Mark move constructor as noexcept. * gdb_ref_ptr.h (class ref_ptr): Mark move constructor as noexcept.
This commit is contained in:
parent
9b2c992cfa
commit
0fa7617d84
9 changed files with 31 additions and 18 deletions
|
@ -78,7 +78,7 @@ class ref_ptr
|
|||
}
|
||||
|
||||
/* Transfer ownership from OTHER. */
|
||||
ref_ptr (ref_ptr &&other)
|
||||
ref_ptr (ref_ptr &&other) noexcept
|
||||
: m_obj (other.m_obj)
|
||||
{
|
||||
other.m_obj = NULL;
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue