FreeChainXenon/binutils-gdb
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Simplify code parsing integers and, in process fix a -Wuninitialized warning.

Browse source
This commit is contained in:
Andrew Cagney 2001-02-16 01:27:46 +00:00
parent 9afc4bbfbb
commit 0f6e1ba6ee
2 changed files with 21 additions and 16 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
gdb/ChangeLog
View file

@ -1,3 +1,8 @@
2001-02-15 Andrew Cagney <ac131313@redhat.com>
* f-exp.y: Include <ctype.h>.
(parse_number): Ensure that ``i'' is always initialized.
2001-02-14 Jim Kingdon <jkingdon@engr.sgi.com> 2001-02-14 Jim Kingdon <jkingdon@engr.sgi.com>
* MAINTAINERS: Add myself to paper trail section. * MAINTAINERS: Add myself to paper trail section.

28
gdb/f-exp.y
View file

@ -53,6 +53,7 @@ Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. */
#include "bfd.h" /* Required by objfiles.h. */ #include "bfd.h" /* Required by objfiles.h. */
#include "symfile.h" /* Required by objfiles.h. */ #include "symfile.h" /* Required by objfiles.h. */
#include "objfiles.h" /* For have_full_symbols and have_partial_symbols */ #include "objfiles.h" /* For have_full_symbols and have_partial_symbols */
#include <ctype.h>
/* Remap normal yacc parser interface names (yyparse, yylex, yyerror, etc), /* Remap normal yacc parser interface names (yyparse, yylex, yyerror, etc),
as well as gratuitiously global symbol names, so we can have multiple as well as gratuitiously global symbol names, so we can have multiple
@ -639,7 +640,6 @@ parse_number (p, len, parsed_float, putithere)
{ {
register LONGEST n = 0; register LONGEST n = 0;
register LONGEST prevn = 0; register LONGEST prevn = 0;
register int i;
register int c; register int c;
register int base = input_radix; register int base = input_radix;
int unsigned_p = 0; int unsigned_p = 0;
@ -697,26 +697,26 @@ parse_number (p, len, parsed_float, putithere)
while (len-- > 0) while (len-- > 0)
{ {
c = *p++; c = *p++;
if (c >= 'A' && c <= 'Z') if (isupper (c))
c += 'a' - 'A'; c = tolower (c);
if (c != 'l' && c != 'u') if (len == 0 && c == 'l')
n *= base;
if (c >= '0' && c <= '9')
n += i = c - '0';
else
{
if (base > 10 && c >= 'a' && c <= 'f')
n += i = c - 'a' + 10;
else if (len == 0 && c == 'l')
long_p = 1; long_p = 1;
else if (len == 0 && c == 'u') else if (len == 0 && c == 'u')
unsigned_p = 1; unsigned_p = 1;
else
{
int i;
if (c >= '0' && c <= '9')
i = c - '0';
else if (c >= 'a' && c <= 'f')
i = c - 'a' + 10;
else else
return ERROR; /* Char not a digit */ return ERROR; /* Char not a digit */
}
if (i >= base) if (i >= base)
return ERROR; /* Invalid digit in this base */ return ERROR; /* Invalid digit in this base */
n *= base;
n += i;
}
/* Portably test for overflow (only works for nonzero values, so make /* Portably test for overflow (only works for nonzero values, so make
a second check for zero). */ a second check for zero). */
if ((prevn >= n) && n != 0) if ((prevn >= n) && n != 0)