FreeChainXenon/binutils-gdb
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Add PPC_MAX_REGISTER_SIZE

Browse source 
gdb/
	* ppc-linux-nat.c (fetch_register): Use PPC_MAX_REGISTER_SIZE.
	(store_register): Likewise.
	* ppc-sysv-tdep.c (ppc_sysv_abi_push_dummy_call): Likewise.
	(get_decimal_float_return_value): Likewise.
	(do_ppc_sysv_return_value): Likewise.
	(ppc64_sysv_abi_push_integer): Likewise.
	(ppc64_sysv_abi_push_freg): Likewise.
	(ppc64_sysv_abi_return_value_base): Likewise.
	(ppc64_sysv_abi_return_value): Likewise.
	* rs6000-aix-tdep.c (rs6000_push_dummy_call): Likewise.
	* rs6000-lynx178-tdep.c (rs6000_lynx178_push_dummy_call): Likewise.
	* rs6000-nat.c: Likewise.
	* rs6000-tdep.c (rs6000_register_to_value): Likewise.
	(rs6000_value_to_register): Likewise.
	* ppc-tdep.h (PPC_MAX_REGISTER_SIZE): Add.
This commit is contained in:
Alan Hayward 2017-05-22 09:23:22 +01:00
parent ca49a96781
commit 0f068fb5e5
8 changed files with 50 additions and 29 deletions
Download patch file Download diff file Expand all files Collapse all files

18
gdb/ChangeLog
View file

@ -1,3 +1,21 @@
2017-05-22 Alan Hayward <alan.hayward@arm.com>
* ppc-linux-nat.c (fetch_register): Use PPC_MAX_REGISTER_SIZE.
(store_register): Likewise.
* ppc-sysv-tdep.c (ppc_sysv_abi_push_dummy_call): Likewise.
(get_decimal_float_return_value): Likewise.
(do_ppc_sysv_return_value): Likewise.
(ppc64_sysv_abi_push_integer): Likewise.
(ppc64_sysv_abi_push_freg): Likewise.
(ppc64_sysv_abi_return_value_base): Likewise.
(ppc64_sysv_abi_return_value): Likewise.
* rs6000-aix-tdep.c (rs6000_push_dummy_call): Likewise.
* rs6000-lynx178-tdep.c (rs6000_lynx178_push_dummy_call): Likewise.
* rs6000-nat.c: Likewise.
* rs6000-tdep.c (rs6000_register_to_value): Likewise.
(rs6000_value_to_register): Likewise.
* ppc-tdep.h (PPC_MAX_REGISTER_SIZE): Add.
2017-05-21 Tom Tromey <tom@tromey.com> 2017-05-21 Tom Tromey <tom@tromey.com>
PR rust/21466: PR rust/21466:

4
gdb/ppc-linux-nat.c
View file

@ -497,7 +497,7 @@ fetch_register (struct regcache *regcache, int tid, int regno)
CORE_ADDR regaddr = ppc_register_u_addr (gdbarch, regno); CORE_ADDR regaddr = ppc_register_u_addr (gdbarch, regno);
int bytes_transferred; int bytes_transferred;
unsigned int offset; /* Offset of registers within the u area. */ unsigned int offset; /* Offset of registers within the u area. */
gdb_byte buf[MAX_REGISTER_SIZE]; gdb_byte buf[PPC_MAX_REGISTER_SIZE];
if (altivec_register_p (gdbarch, regno)) if (altivec_register_p (gdbarch, regno))
{ {
@ -979,7 +979,7 @@ store_register (const struct regcache *regcache, int tid, int regno)
CORE_ADDR regaddr = ppc_register_u_addr (gdbarch, regno); CORE_ADDR regaddr = ppc_register_u_addr (gdbarch, regno);
int i; int i;
size_t bytes_to_transfer; size_t bytes_to_transfer;
gdb_byte buf[MAX_REGISTER_SIZE]; gdb_byte buf[PPC_MAX_REGISTER_SIZE];
if (altivec_register_p (gdbarch, regno)) if (altivec_register_p (gdbarch, regno))
{ {

34
gdb/ppc-sysv-tdep.c
View file

@ -134,7 +134,7 @@ ppc_sysv_abi_push_dummy_call (struct gdbarch *gdbarch, struct value *function,
{ {
/* Always store the floating point value using /* Always store the floating point value using
the register's floating-point format. */ the register's floating-point format. */
gdb_byte regval[MAX_REGISTER_SIZE]; gdb_byte regval[PPC_MAX_REGISTER_SIZE];
struct type *regtype struct type *regtype
= register_type (gdbarch, tdep->ppc_fp0_regnum + freg); = register_type (gdbarch, tdep->ppc_fp0_regnum + freg);
convert_typed_floating (val, type, regval, regtype); convert_typed_floating (val, type, regval, regtype);
@ -278,7 +278,7 @@ ppc_sysv_abi_push_dummy_call (struct gdbarch *gdbarch, struct value *function,
{ {
if (write_pass) if (write_pass)
{ {
gdb_byte regval[MAX_REGISTER_SIZE]; gdb_byte regval[PPC_MAX_REGISTER_SIZE];
const gdb_byte *p; const gdb_byte *p;
/* 32-bit decimal floats are right aligned in the /* 32-bit decimal floats are right aligned in the
@ -364,7 +364,7 @@ ppc_sysv_abi_push_dummy_call (struct gdbarch *gdbarch, struct value *function,
if (write_pass) if (write_pass)
{ {
int regnum = tdep->ppc_fp0_regnum + freg; int regnum = tdep->ppc_fp0_regnum + freg;
gdb_byte regval[MAX_REGISTER_SIZE]; gdb_byte regval[PPC_MAX_REGISTER_SIZE];
struct type *regtype struct type *regtype
= register_type (gdbarch, regnum); = register_type (gdbarch, regnum);
convert_typed_floating (elval, eltype, convert_typed_floating (elval, eltype,
@ -411,7 +411,7 @@ ppc_sysv_abi_push_dummy_call (struct gdbarch *gdbarch, struct value *function,
} }
else else
{ {
gdb_byte word[MAX_REGISTER_SIZE]; gdb_byte word[PPC_MAX_REGISTER_SIZE];
store_unsigned_integer (word, tdep->wordsize, byte_order, store_unsigned_integer (word, tdep->wordsize, byte_order,
unpack_long (eltype, elval)); unpack_long (eltype, elval));
@ -516,8 +516,8 @@ ppc_sysv_abi_push_dummy_call (struct gdbarch *gdbarch, struct value *function,
{ {
/* Reduce the parameter down to something that fits in a /* Reduce the parameter down to something that fits in a
"word". */ "word". */
gdb_byte word[MAX_REGISTER_SIZE]; gdb_byte word[PPC_MAX_REGISTER_SIZE];
memset (word, 0, MAX_REGISTER_SIZE); memset (word, 0, PPC_MAX_REGISTER_SIZE);
if (len > tdep->wordsize if (len > tdep->wordsize
|| TYPE_CODE (type) == TYPE_CODE_STRUCT || TYPE_CODE (type) == TYPE_CODE_STRUCT
|| TYPE_CODE (type) == TYPE_CODE_UNION) || TYPE_CODE (type) == TYPE_CODE_UNION)
@ -623,7 +623,7 @@ get_decimal_float_return_value (struct gdbarch *gdbarch, struct type *valtype,
{ {
if (writebuf != NULL) if (writebuf != NULL)
{ {
gdb_byte regval[MAX_REGISTER_SIZE]; gdb_byte regval[PPC_MAX_REGISTER_SIZE];
const gdb_byte *p; const gdb_byte *p;
/* 32-bit decimal float is right aligned in the doubleword. */ /* 32-bit decimal float is right aligned in the doubleword. */
@ -706,7 +706,7 @@ do_ppc_sysv_return_value (struct gdbarch *gdbarch, struct type *func_type,
{ {
/* Floats and doubles stored in "f1". Convert the value to /* Floats and doubles stored in "f1". Convert the value to
the required type. */ the required type. */
gdb_byte regval[MAX_REGISTER_SIZE]; gdb_byte regval[PPC_MAX_REGISTER_SIZE];
struct type *regtype = register_type (gdbarch, struct type *regtype = register_type (gdbarch,
tdep->ppc_fp0_regnum + 1); tdep->ppc_fp0_regnum + 1);
regcache_cooked_read (regcache, tdep->ppc_fp0_regnum + 1, regval); regcache_cooked_read (regcache, tdep->ppc_fp0_regnum + 1, regval);
@ -716,7 +716,7 @@ do_ppc_sysv_return_value (struct gdbarch *gdbarch, struct type *func_type,
{ {
/* Floats and doubles stored in "f1". Convert the value to /* Floats and doubles stored in "f1". Convert the value to
the register's "double" type. */ the register's "double" type. */
gdb_byte regval[MAX_REGISTER_SIZE]; gdb_byte regval[PPC_MAX_REGISTER_SIZE];
struct type *regtype = register_type (gdbarch, tdep->ppc_fp0_regnum); struct type *regtype = register_type (gdbarch, tdep->ppc_fp0_regnum);
convert_typed_floating (writebuf, type, regval, regtype); convert_typed_floating (writebuf, type, regval, regtype);
regcache_cooked_write (regcache, tdep->ppc_fp0_regnum + 1, regval); regcache_cooked_write (regcache, tdep->ppc_fp0_regnum + 1, regval);
@ -847,7 +847,7 @@ do_ppc_sysv_return_value (struct gdbarch *gdbarch, struct type *func_type,
if (TYPE_CODE (eltype) == TYPE_CODE_FLT) if (TYPE_CODE (eltype) == TYPE_CODE_FLT)
{ {
int regnum = tdep->ppc_fp0_regnum + 1 + i; int regnum = tdep->ppc_fp0_regnum + 1 + i;
gdb_byte regval[MAX_REGISTER_SIZE]; gdb_byte regval[PPC_MAX_REGISTER_SIZE];
struct type *regtype = register_type (gdbarch, regnum); struct type *regtype = register_type (gdbarch, regnum);
if (writebuf != NULL) if (writebuf != NULL)
@ -977,7 +977,7 @@ do_ppc_sysv_return_value (struct gdbarch *gdbarch, struct type *func_type,
/* GCC screwed up for structures or unions whose size is less /* GCC screwed up for structures or unions whose size is less
than or equal to 8 bytes.. Instead of left-aligning, it than or equal to 8 bytes.. Instead of left-aligning, it
right-aligns the data into the buffer formed by r3, r4. */ right-aligns the data into the buffer formed by r3, r4. */
gdb_byte regvals[MAX_REGISTER_SIZE * 2]; gdb_byte regvals[PPC_MAX_REGISTER_SIZE * 2];
int len = TYPE_LENGTH (type); int len = TYPE_LENGTH (type);
int offset = (2 * tdep->wordsize - len) % tdep->wordsize; int offset = (2 * tdep->wordsize - len) % tdep->wordsize;
@ -1010,7 +1010,7 @@ do_ppc_sysv_return_value (struct gdbarch *gdbarch, struct type *func_type,
/* This matches SVr4 PPC, it does not match GCC. */ /* This matches SVr4 PPC, it does not match GCC. */
/* The value is right-padded to 8 bytes and then loaded, as /* The value is right-padded to 8 bytes and then loaded, as
two "words", into r3/r4. */ two "words", into r3/r4. */
gdb_byte regvals[MAX_REGISTER_SIZE * 2]; gdb_byte regvals[PPC_MAX_REGISTER_SIZE * 2];
regcache_cooked_read (regcache, tdep->ppc_gp0_regnum + 3, regcache_cooked_read (regcache, tdep->ppc_gp0_regnum + 3,
regvals + 0 * tdep->wordsize); regvals + 0 * tdep->wordsize);
if (TYPE_LENGTH (type) > tdep->wordsize) if (TYPE_LENGTH (type) > tdep->wordsize)
@ -1023,7 +1023,7 @@ do_ppc_sysv_return_value (struct gdbarch *gdbarch, struct type *func_type,
/* This matches SVr4 PPC, it does not match GCC. */ /* This matches SVr4 PPC, it does not match GCC. */
/* The value is padded out to 8 bytes and then loaded, as /* The value is padded out to 8 bytes and then loaded, as
two "words" into r3/r4. */ two "words" into r3/r4. */
gdb_byte regvals[MAX_REGISTER_SIZE * 2]; gdb_byte regvals[PPC_MAX_REGISTER_SIZE * 2];
memset (regvals, 0, sizeof regvals); memset (regvals, 0, sizeof regvals);
memcpy (regvals, writebuf, TYPE_LENGTH (type)); memcpy (regvals, writebuf, TYPE_LENGTH (type));
regcache_cooked_write (regcache, tdep->ppc_gp0_regnum + 3, regcache_cooked_write (regcache, tdep->ppc_gp0_regnum + 3,
@ -1340,7 +1340,7 @@ ppc64_sysv_abi_push_integer (struct gdbarch *gdbarch, ULONGEST val,
{ {
struct gdbarch_tdep *tdep = gdbarch_tdep (gdbarch); struct gdbarch_tdep *tdep = gdbarch_tdep (gdbarch);
enum bfd_endian byte_order = gdbarch_byte_order (gdbarch); enum bfd_endian byte_order = gdbarch_byte_order (gdbarch);
gdb_byte buf[MAX_REGISTER_SIZE]; gdb_byte buf[PPC_MAX_REGISTER_SIZE];
if (argpos->regcache) if (argpos->regcache)
store_unsigned_integer (buf, tdep->wordsize, byte_order, val); store_unsigned_integer (buf, tdep->wordsize, byte_order, val);
@ -1369,7 +1369,7 @@ ppc64_sysv_abi_push_freg (struct gdbarch *gdbarch,
{ {
int regnum = tdep->ppc_fp0_regnum + argpos->freg; int regnum = tdep->ppc_fp0_regnum + argpos->freg;
struct type *regtype = register_type (gdbarch, regnum); struct type *regtype = register_type (gdbarch, regnum);
gdb_byte regval[MAX_REGISTER_SIZE]; gdb_byte regval[PPC_MAX_REGISTER_SIZE];
convert_typed_floating (val, type, regval, regtype); convert_typed_floating (val, type, regval, regtype);
regcache_cooked_write (argpos->regcache, regnum, regval); regcache_cooked_write (argpos->regcache, regnum, regval);
@ -1814,7 +1814,7 @@ ppc64_sysv_abi_return_value_base (struct gdbarch *gdbarch, struct type *valtype,
{ {
int regnum = tdep->ppc_fp0_regnum + 1 + index; int regnum = tdep->ppc_fp0_regnum + 1 + index;
struct type *regtype = register_type (gdbarch, regnum); struct type *regtype = register_type (gdbarch, regnum);
gdb_byte regval[MAX_REGISTER_SIZE]; gdb_byte regval[PPC_MAX_REGISTER_SIZE];
if (writebuf != NULL) if (writebuf != NULL)
{ {
@ -2071,7 +2071,7 @@ ppc64_sysv_abi_return_value (struct gdbarch *gdbarch, struct value *function,
for (i = 0; i < n_regs; i++) for (i = 0; i < n_regs; i++)
{ {
gdb_byte regval[MAX_REGISTER_SIZE]; gdb_byte regval[PPC_MAX_REGISTER_SIZE];
int regnum = tdep->ppc_gp0_regnum + 3 + i; int regnum = tdep->ppc_gp0_regnum + 3 + i;
int offset = i * tdep->wordsize; int offset = i * tdep->wordsize;
int len = TYPE_LENGTH (valtype) - offset; int len = TYPE_LENGTH (valtype) - offset;

3
gdb/ppc-tdep.h
View file

@ -305,6 +305,9 @@ enum {
PPC_NUM_REGS PPC_NUM_REGS
}; };
/* Big enough to hold the size of the largest register in bytes. */
#define PPC_MAX_REGISTER_SIZE 64
/* An instruction to match. */ /* An instruction to match. */
struct ppc_insn_pattern struct ppc_insn_pattern

6
gdb/rs6000-aix-tdep.c
View file

@ -253,7 +253,7 @@ rs6000_push_dummy_call (struct gdbarch *gdbarch, struct value *function,
Always store the floating point value using the register's Always store the floating point value using the register's
floating-point format. */ floating-point format. */
const int fp_regnum = tdep->ppc_fp0_regnum + 1 + f_argno; const int fp_regnum = tdep->ppc_fp0_regnum + 1 + f_argno;
gdb_byte reg_val[MAX_REGISTER_SIZE]; gdb_byte reg_val[PPC_MAX_REGISTER_SIZE];
struct type *reg_type = register_type (gdbarch, fp_regnum); struct type *reg_type = register_type (gdbarch, fp_regnum);
gdb_assert (len <= 8); gdb_assert (len <= 8);
@ -270,7 +270,7 @@ rs6000_push_dummy_call (struct gdbarch *gdbarch, struct value *function,
/* Argument takes more than one register. */ /* Argument takes more than one register. */
while (argbytes < len) while (argbytes < len)
{ {
gdb_byte word[MAX_REGISTER_SIZE]; gdb_byte word[PPC_MAX_REGISTER_SIZE];
memset (word, 0, reg_size); memset (word, 0, reg_size);
memcpy (word, memcpy (word,
((char *) value_contents (arg)) + argbytes, ((char *) value_contents (arg)) + argbytes,
@ -290,7 +290,7 @@ rs6000_push_dummy_call (struct gdbarch *gdbarch, struct value *function,
else else
{ {
/* Argument can fit in one register. No problem. */ /* Argument can fit in one register. No problem. */
gdb_byte word[MAX_REGISTER_SIZE]; gdb_byte word[PPC_MAX_REGISTER_SIZE];
memset (word, 0, reg_size); memset (word, 0, reg_size);
memcpy (word, value_contents (arg), len); memcpy (word, value_contents (arg), len);

6
gdb/rs6000-lynx178-tdep.c
View file

@ -105,7 +105,7 @@ rs6000_lynx178_push_dummy_call (struct gdbarch *gdbarch,
Always store the floating point value using the register's Always store the floating point value using the register's
floating-point format. */ floating-point format. */
const int fp_regnum = tdep->ppc_fp0_regnum + 1 + f_argno; const int fp_regnum = tdep->ppc_fp0_regnum + 1 + f_argno;
gdb_byte reg_val[MAX_REGISTER_SIZE]; gdb_byte reg_val[PPC_MAX_REGISTER_SIZE];
struct type *reg_type = register_type (gdbarch, fp_regnum); struct type *reg_type = register_type (gdbarch, fp_regnum);
gdb_assert (len <= 8); gdb_assert (len <= 8);
@ -122,7 +122,7 @@ rs6000_lynx178_push_dummy_call (struct gdbarch *gdbarch,
/* Argument takes more than one register. */ /* Argument takes more than one register. */
while (argbytes < len) while (argbytes < len)
{ {
gdb_byte word[MAX_REGISTER_SIZE]; gdb_byte word[PPC_MAX_REGISTER_SIZE];
memset (word, 0, reg_size); memset (word, 0, reg_size);
memcpy (word, memcpy (word,
((char *) value_contents (arg)) + argbytes, ((char *) value_contents (arg)) + argbytes,
@ -142,7 +142,7 @@ rs6000_lynx178_push_dummy_call (struct gdbarch *gdbarch,
else else
{ {
/* Argument can fit in one register. No problem. */ /* Argument can fit in one register. No problem. */
gdb_byte word[MAX_REGISTER_SIZE]; gdb_byte word[PPC_MAX_REGISTER_SIZE];
memset (word, 0, reg_size); memset (word, 0, reg_size);
memcpy (word, value_contents (arg), len); memcpy (word, value_contents (arg), len);

4
gdb/rs6000-nat.c
View file

@ -162,7 +162,7 @@ static void
fetch_register (struct regcache *regcache, int regno) fetch_register (struct regcache *regcache, int regno)
{ {
struct gdbarch *gdbarch = get_regcache_arch (regcache); struct gdbarch *gdbarch = get_regcache_arch (regcache);
int addr[MAX_REGISTER_SIZE]; int addr[PPC_MAX_REGISTER_SIZE];
int nr, isfloat; int nr, isfloat;
pid_t pid = ptid_get_pid (regcache_get_ptid (regcache)); pid_t pid = ptid_get_pid (regcache_get_ptid (regcache));
@ -221,7 +221,7 @@ static void
store_register (struct regcache *regcache, int regno) store_register (struct regcache *regcache, int regno)
{ {
struct gdbarch *gdbarch = get_regcache_arch (regcache); struct gdbarch *gdbarch = get_regcache_arch (regcache);
int addr[MAX_REGISTER_SIZE]; int addr[PPC_MAX_REGISTER_SIZE];
int nr, isfloat; int nr, isfloat;
pid_t pid = ptid_get_pid (regcache_get_ptid (regcache)); pid_t pid = ptid_get_pid (regcache_get_ptid (regcache));

4
gdb/rs6000-tdep.c
View file

@ -2611,7 +2611,7 @@ rs6000_register_to_value (struct frame_info *frame,
int *optimizedp, int *unavailablep) int *optimizedp, int *unavailablep)
{ {
struct gdbarch *gdbarch = get_frame_arch (frame); struct gdbarch *gdbarch = get_frame_arch (frame);
gdb_byte from[MAX_REGISTER_SIZE]; gdb_byte from[PPC_MAX_REGISTER_SIZE];
gdb_assert (TYPE_CODE (type) == TYPE_CODE_FLT); gdb_assert (TYPE_CODE (type) == TYPE_CODE_FLT);
@ -2633,7 +2633,7 @@ rs6000_value_to_register (struct frame_info *frame,
const gdb_byte *from) const gdb_byte *from)
{ {
struct gdbarch *gdbarch = get_frame_arch (frame); struct gdbarch *gdbarch = get_frame_arch (frame);
gdb_byte to[MAX_REGISTER_SIZE]; gdb_byte to[PPC_MAX_REGISTER_SIZE];
gdb_assert (TYPE_CODE (type) == TYPE_CODE_FLT); gdb_assert (TYPE_CODE (type) == TYPE_CODE_FLT);