Constify add_com
This changes add_com to take a cmd_const_cfunc_ftype, and then fixes up all the command implementations. In most cases this is trivial. In a couple of places I had to again introduce a temporary non-const overload. These overloads will be removed when add_info is constified. gdb/ChangeLog 2017-11-07 Tom Tromey <tom@tromey.com> * solib.h (no_shared_libraries): Constify. * frame.h (return_command): Constify. * cli/cli-cmds.h (quit_command): Constify. * top.h (quit_command, execute_command): Constify. * target.h (flash_erase_command): Constify. * inferior.h (set_inferior_args, attach_command): Constify. * tracepoint.h (start_tracing, stop_tracing): Constify. * breakpoint.h (break_command, tbreak_command) (hbreak_command_wrapper, thbreak_command_wrapper) (rbreak_command_wrapper, watch_command_wrapper) (awatch_command_wrapper, rwatch_command_wrapper) (get_tracepoint_by_number): Constify. * symtab.c (info_variables_command, rbreak_command) (symtab_symbol_info): Constify. (info_variables_command): Add non-const overload. * top.c (dont_repeat_command): Constify. * breakpoint.c (ignore_command, commands_command) (condition_command, tbreak_command, hbreak_command) (thbreak_command, clear_command, break_command) (info_breakpoints_command, watch_command, rwatch_command) (awatch_command, trace_command, ftrace_command, strace_command) (trace_pass_command, break_range_command, dprintf_command) (agent_printf_command, get_tracepoint_by_number) (watch_maybe_just_location, trace_pass_command): Constify. (info_breakpoints_command): Add non-const overload. * tracefile.c (tsave_command): Constify. * infcmd.c (attach_command, disconnect_command, signal_command) (queue_signal_command, stepi_command, nexti_command) (finish_command, next_command, step_command, until_command) (advance_command, jump_command, continue_command, run_command) (start_command, starti_command, interrupt_command) (run_command_1, set_inferior_args, step_1): Constify. * inferior.c (add_inferior_command, remove_inferior_command) (clone_inferior_command): Constify. * linux-fork.c (checkpoint_command, restart_command): Constify. * windows-nat.c (signal_event_command): Constify. * guile/guile.c (guile_repl_command, guile_command): Constify. * printcmd.c (x_command, display_command, printf_command) (output_command, set_command, call_command, print_command) (eval_command): Constify. (non_const_set_command): Remove. (_initialize_printcmd): Update. * source.c (forward_search_command, reverse_search_command): Constify. * jit.c (jit_reader_load_command, jit_reader_unload_command): Constify. * infrun.c (handle_command): Constify. * memattr.c (mem_command): Constify. * stack.c (return_command, up_command, up_silently_command) (down_command, down_silently_command, frame_command) (backtrace_command, func_command, backtrace_command_1): Constify. (backtrace_command): Add non-const overload. * remote-sim.c (simulator_command): Constify. * exec.c (set_section_command): Constify. * tracepoint.c (tdump_command, trace_variable_command) (tstatus_command, tstop_command, tstart_command) (end_actions_pseudocommand, while_stepping_pseudocommand) (collect_pseudocommand, teval_pseudocommand, actions_command) (start_tracing, stop_tracing): Constify. * value.c (init_if_undefined_command): Constify. * tui/tui-stack.c (tui_update_command): Constify. * tui/tui-win.c (tui_refresh_all_command) (tui_set_tab_width_command, tui_set_win_height_command) (tui_set_focus_command, tui_scroll_forward_command) (tui_scroll_backward_command, tui_scroll_left_command) (tui_scroll_right_command, parse_scrolling_args, tui_set_focus) (tui_set_win_height): Constify. * tui/tui-layout.c (tui_layout_command): Constify. * procfs.c (proc_trace_syscalls, proc_trace_sysentry_cmd) (proc_trace_sysexit_cmd, proc_untrace_sysentry_cmd) (proc_untrace_sysexit_cmd): Constify. * remote.c (threadlist_test_cmd, threadinfo_test_cmd) (threadset_test_cmd, threadlist_update_test_cmd) (threadalive_test): Constify. * objc-lang.c (print_object_command): Constify. * command.h (add_com): Constify. * cli/cli-dump.c (restore_command): Constify. * cli/cli-cmds.c (pwd_command, echo_command, quit_command) (help_command, complete_command, shell_command, edit_command) (list_command, disassemble_command, make_command) (apropos_command, alias_command): Constify. * cli/cli-script.c (document_command, define_command) (while_command, if_command, validate_comname): Constify. * cli/cli-decode.c (struct cmd_list_element): Change type of "fun". * target.c (do_monitor_command, flash_erase_command): Constify. * regcache.c (reg_flush_command): Constify. * reverse.c (reverse_step, reverse_next, reverse_stepi) (reverse_nexti, reverse_continue, reverse_finish) (save_bookmark_command, goto_bookmark_command) (exec_reverse_once): Constify. * python/python.c (python_interactive_command, python_command): Constify. * typeprint.c (ptype_command, whatis_command, whatis_exp): Constify. * solib.c (sharedlibrary_command, no_shared_libraries): Constify. * gcore.c (gcore_command): Constify.
This commit is contained in:
Tom Tromey
parent
85c4be7c83
commit
0b39b52e6e
46 changed files with 355 additions and 318 deletions
62
gdb/infcmd.c
62
gdb/infcmd.c
|
|
@ -66,29 +66,11 @@ static void info_registers_command (char *, int);
|
|||
|
||||
static void until_next_command (int);
|
||||
|
||||
static void until_command (char *, int);
|
||||
|
||||
static void path_command (char *, int);
|
||||
|
||||
static void info_float_command (char *, int);
|
||||
|
||||
static void disconnect_command (char *, int);
|
||||
|
||||
static void info_program_command (char *, int);
|
||||
|
||||
static void finish_command (char *, int);
|
||||
|
||||
static void signal_command (char *, int);
|
||||
|
||||
static void jump_command (char *, int);
|
||||
|
||||
static void step_1 (int, int, char *);
|
||||
|
||||
static void next_command (char *, int);
|
||||
|
||||
static void step_command (char *, int);
|
||||
|
||||
static void run_command (char *, int);
|
||||
static void step_1 (int, int, const char *);
|
||||
|
||||
#define ERROR_NO_INFERIOR \
|
||||
if (!target_has_execution) error (_("The program is not being run."));
|
||||
|
|
@ -204,7 +186,7 @@ get_inferior_args (void)
|
|||
NEWARGS is not transferred. */
|
||||
|
||||
void
|
||||
set_inferior_args (char *newargs)
|
||||
set_inferior_args (const char *newargs)
|
||||
{
|
||||
xfree (current_inferior ()->args);
|
||||
current_inferior ()->args = newargs ? xstrdup (newargs) : NULL;
|
||||
|
|
@ -585,7 +567,7 @@ enum run_how
|
|||
requested by RUN_HOW. */
|
||||
|
||||
static void
|
||||
run_command_1 (char *args, int from_tty, enum run_how run_how)
|
||||
run_command_1 (const char *args, int from_tty, enum run_how run_how)
|
||||
{
|
||||
const char *exec_file;
|
||||
struct cleanup *old_chain;
|
||||
|
|
@ -708,7 +690,7 @@ run_command_1 (char *args, int from_tty, enum run_how run_how)
|
|||
}
|
||||
|
||||
static void
|
||||
run_command (char *args, int from_tty)
|
||||
run_command (const char *args, int from_tty)
|
||||
{
|
||||
run_command_1 (args, from_tty, RUN_NORMAL);
|
||||
}
|
||||
|
|
@ -717,7 +699,7 @@ run_command (char *args, int from_tty)
|
|||
program. */
|
||||
|
||||
static void
|
||||
start_command (char *args, int from_tty)
|
||||
start_command (const char *args, int from_tty)
|
||||
{
|
||||
/* Some languages such as Ada need to search inside the program
|
||||
minimal symbols for the location where to put the temporary
|
||||
|
|
@ -733,7 +715,7 @@ start_command (char *args, int from_tty)
|
|||
instruction. */
|
||||
|
||||
static void
|
||||
starti_command (char *args, int from_tty)
|
||||
starti_command (const char *args, int from_tty)
|
||||
{
|
||||
run_command_1 (args, from_tty, RUN_STOP_AT_FIRST_INSN);
|
||||
}
|
||||
|
|
@ -843,7 +825,7 @@ continue_1 (int all_threads)
|
|||
/* continue [-a] [proceed-count] [&] */
|
||||
|
||||
static void
|
||||
continue_command (char *args, int from_tty)
|
||||
continue_command (const char *args, int from_tty)
|
||||
{
|
||||
int async_exec;
|
||||
int all_threads = 0;
|
||||
|
|
@ -949,7 +931,7 @@ set_step_frame (void)
|
|||
/* Step until outside of current statement. */
|
||||
|
||||
static void
|
||||
step_command (char *count_string, int from_tty)
|
||||
step_command (const char *count_string, int from_tty)
|
||||
{
|
||||
step_1 (0, 0, count_string);
|
||||
}
|
||||
|
|
@ -957,7 +939,7 @@ step_command (char *count_string, int from_tty)
|
|||
/* Likewise, but skip over subroutine calls as if single instructions. */
|
||||
|
||||
static void
|
||||
next_command (char *count_string, int from_tty)
|
||||
next_command (const char *count_string, int from_tty)
|
||||
{
|
||||
step_1 (1, 0, count_string);
|
||||
}
|
||||
|
|
@ -965,13 +947,13 @@ next_command (char *count_string, int from_tty)
|
|||
/* Likewise, but step only one instruction. */
|
||||
|
||||
static void
|
||||
stepi_command (char *count_string, int from_tty)
|
||||
stepi_command (const char *count_string, int from_tty)
|
||||
{
|
||||
step_1 (0, 1, count_string);
|
||||
}
|
||||
|
||||
static void
|
||||
nexti_command (char *count_string, int from_tty)
|
||||
nexti_command (const char *count_string, int from_tty)
|
||||
{
|
||||
step_1 (1, 1, count_string);
|
||||
}
|
||||
|
|
@ -1054,7 +1036,7 @@ step_command_fsm_prepare (struct step_command_fsm *sm,
|
|||
static int prepare_one_step (struct step_command_fsm *sm);
|
||||
|
||||
static void
|
||||
step_1 (int skip_subroutines, int single_inst, char *count_string)
|
||||
step_1 (int skip_subroutines, int single_inst, const char *count_string)
|
||||
{
|
||||
int count;
|
||||
int async_exec;
|
||||
|
|
@ -1242,7 +1224,7 @@ prepare_one_step (struct step_command_fsm *sm)
|
|||
/* Continue program at specified address. */
|
||||
|
||||
static void
|
||||
jump_command (char *arg, int from_tty)
|
||||
jump_command (const char *arg, int from_tty)
|
||||
{
|
||||
struct gdbarch *gdbarch = get_current_arch ();
|
||||
CORE_ADDR addr;
|
||||
|
|
@ -1323,7 +1305,7 @@ jump_command (char *arg, int from_tty)
|
|||
/* Continue program giving it specified signal. */
|
||||
|
||||
static void
|
||||
signal_command (char *signum_exp, int from_tty)
|
||||
signal_command (const char *signum_exp, int from_tty)
|
||||
{
|
||||
enum gdb_signal oursig;
|
||||
int async_exec;
|
||||
|
|
@ -1420,7 +1402,7 @@ signal_command (char *signum_exp, int from_tty)
|
|||
/* Queue a signal to be delivered to the current thread. */
|
||||
|
||||
static void
|
||||
queue_signal_command (char *signum_exp, int from_tty)
|
||||
queue_signal_command (const char *signum_exp, int from_tty)
|
||||
{
|
||||
enum gdb_signal oursig;
|
||||
struct thread_info *tp;
|
||||
|
|
@ -1601,7 +1583,7 @@ until_next_command (int from_tty)
|
|||
}
|
||||
|
||||
static void
|
||||
until_command (char *arg, int from_tty)
|
||||
until_command (const char *arg, int from_tty)
|
||||
{
|
||||
int async_exec;
|
||||
|
||||
|
|
@ -1623,7 +1605,7 @@ until_command (char *arg, int from_tty)
|
|||
}
|
||||
|
||||
static void
|
||||
advance_command (char *arg, int from_tty)
|
||||
advance_command (const char *arg, int from_tty)
|
||||
{
|
||||
int async_exec;
|
||||
|
||||
|
|
@ -2003,7 +1985,7 @@ skip_finish_frames (struct frame_info *frame)
|
|||
frame will return to, then continue. */
|
||||
|
||||
static void
|
||||
finish_command (char *arg, int from_tty)
|
||||
finish_command (const char *arg, int from_tty)
|
||||
{
|
||||
struct frame_info *frame;
|
||||
int async_exec;
|
||||
|
|
@ -2291,7 +2273,7 @@ path_info (const char *args, int from_tty)
|
|||
/* Add zero or more directories to the front of the execution path. */
|
||||
|
||||
static void
|
||||
path_command (char *dirname, int from_tty)
|
||||
path_command (const char *dirname, int from_tty)
|
||||
{
|
||||
char *exec_path;
|
||||
const char *env;
|
||||
|
|
@ -2815,7 +2797,7 @@ attach_command_continuation_free_args (void *args)
|
|||
and allows us to start debugging it. */
|
||||
|
||||
void
|
||||
attach_command (char *args, int from_tty)
|
||||
attach_command (const char *args, int from_tty)
|
||||
{
|
||||
int async_exec;
|
||||
struct target_ops *attach_target;
|
||||
|
|
@ -3035,7 +3017,7 @@ detach_command (const char *args, int from_tty)
|
|||
stopped processes on some native platforms (e.g. GNU/Linux). */
|
||||
|
||||
static void
|
||||
disconnect_command (char *args, int from_tty)
|
||||
disconnect_command (const char *args, int from_tty)
|
||||
{
|
||||
dont_repeat (); /* Not for the faint of heart. */
|
||||
query_if_trace_running (from_tty);
|
||||
|
|
@ -3079,7 +3061,7 @@ interrupt_target_1 (int all_threads)
|
|||
if the `-a' switch is used. */
|
||||
|
||||
static void
|
||||
interrupt_command (char *args, int from_tty)
|
||||
interrupt_command (const char *args, int from_tty)
|
||||
{
|
||||
if (target_can_async_p ())
|
||||
{
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue