FreeChainXenon/binutils-gdb
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix problems in the sim sources discovered by running the cppcheck static analysis tool.

Browse source 
erc32	PR 18273
	* sis.c (main): Remove unreachable code.

m68hc11	* gencode.c (gen_fetch_operands): Remove unreachable code.

ppc	* hw_htab.c (htab_map_binary): Fix overlap check.

common	* sim-fpu.c (INLINE_SIM_FPU): Fix static analysis warning by
	increasing parenthesis around casts to signed values.
This commit is contained in:
Nick Clifton 2015-04-29 16:02:02 +01:00
parent 998d2a3ef3
commit 0a13382c8e
8 changed files with 29 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
sim/common/ChangeLog
View file

@ -1,3 +1,10 @@
2015-04-29 Nick Clifton <nickc@redhat.com>
PR 18273
* sim-fpu.c (INLINE_SIM_FPU): Fix static analysis warning by
increasing parenthesis around casts to signed values.
2015-04-21 Mike Frysinger <vapier@gentoo.org> 2015-04-21 Mike Frysinger <vapier@gentoo.org>
* gennltvals.sh: Add mcore support. * gennltvals.sh: Add mcore support.

4
sim/common/sim-fpu.c
View file

@ -1107,7 +1107,7 @@ sim_fpu_add (sim_fpu *f,
/* sign? */ /* sign? */
f->class = sim_fpu_class_number; f->class = sim_fpu_class_number;
if ((signed64) f->fraction >= 0) if (((signed64) f->fraction) >= 0)
f->sign = 0; f->sign = 0;
else else
{ {
@ -1261,7 +1261,7 @@ sim_fpu_sub (sim_fpu *f,
/* sign? */ /* sign? */
f->class = sim_fpu_class_number; f->class = sim_fpu_class_number;
if ((signed64) f->fraction >= 0) if (((signed64) f->fraction) >= 0)
f->sign = 0; f->sign = 0;
else else
{ {

5
sim/erc32/ChangeLog
View file

@ -1,3 +1,8 @@
2015-04-29 Nick Clifton <nickc@redhat.com>
PR 18273
* sis.c (main): Remove unreachable code.
2015-04-24 David Binderman <dcb314@hotmail.com> 2015-04-24 David Binderman <dcb314@hotmail.com>
Nick Clifton <nickc@redhat.com> Nick Clifton <nickc@redhat.com>

4
sim/erc32/sis.c
View file

@ -169,7 +169,7 @@ main(argc, argv)
while (stat < argc) { while (stat < argc) {
if (argv[stat][0] == '-') { if (argv[stat][0] == '-') {
if (strcmp(argv[stat], "-v") == 0) { if (strcmp(argv[stat], "-v") == 0) {
sis_verbose = 1; sis_verbose += 1;
} else if (strcmp(argv[stat], "-c") == 0) { } else if (strcmp(argv[stat], "-c") == 0) {
if ((stat + 1) < argc) { if ((stat + 1) < argc) {
copt = 1; copt = 1;
@ -202,8 +202,6 @@ main(argc, argv)
#endif #endif
} else if (strcmp(argv[stat], "-dumbio") == 0) { } else if (strcmp(argv[stat], "-dumbio") == 0) {
dumbio = 1; dumbio = 1;
} else if (strcmp(argv[stat], "-v") == 0) {
sis_verbose += 1;
} else { } else {
printf("unknown option %s\n", argv[stat]); printf("unknown option %s\n", argv[stat]);
usage(); usage();

5
sim/m68hc11/ChangeLog
View file

@ -1,3 +1,8 @@
2015-04-29 Nick Clifton <nickc@redhat.com>
PR 18273
* gencode.c (gen_fetch_operands): Remove unreachable code.
2015-04-18 Mike Frysinger <vapier@gentoo.org> 2015-04-18 Mike Frysinger <vapier@gentoo.org>
* sim-main.h (SIM_CPU): Delete. * sim-main.h (SIM_CPU): Delete.

3
sim/m68hc11/gencode.c
View file

@ -1466,6 +1466,8 @@ gen_fetch_operands (FILE *fp, int col,
vars[cur_var], operand_size, operand_size); vars[cur_var], operand_size, operand_size);
operands += 1; operands += 1;
} }
#if 0 /* This code is never executed (see strncmp above), but it has not been
removed because it may be that there is a typo in strncmp test below. */
else if (strncmp (operands, "]", 1) == 0) else if (strncmp (operands, "]", 1) == 0)
{ {
current_insn_size += 1; current_insn_size += 1;
@ -1473,6 +1475,7 @@ gen_fetch_operands (FILE *fp, int col,
vars[cur_var], operand_size, operand_size); vars[cur_var], operand_size, operand_size);
operands += 1; operands += 1;
} }
#endif
else else
{ {
fatal_error (opcode, "Unknown operand"); fatal_error (opcode, "Unknown operand");

5
sim/ppc/ChangeLog
View file

@ -1,3 +1,8 @@
2015-04-29 Nick Clifton <nickc@redhat.com>
PR 18273
* hw_htab.c (htab_map_binary): Fix overlap check.
2015-04-13 Mike Frysinger <vapier@gentoo.org> 2015-04-13 Mike Frysinger <vapier@gentoo.org>
* Makefile.in (version.o): Change to using create-version.sh from gdb. * Makefile.in (version.o): Change to using create-version.sh from gdb.

2
sim/ppc/hw_htab.c
View file

@ -549,7 +549,7 @@ htab_map_binary(device *me,
if ((sizes.text_base <= sizes.data_base if ((sizes.text_base <= sizes.data_base
&& sizes.text_bound >= sizes.data_bound) && sizes.text_bound >= sizes.data_bound)
|| (sizes.data_base <= sizes.text_base || (sizes.data_base <= sizes.text_base
&& sizes.data_bound >= sizes.data_bound) && sizes.data_bound >= sizes.text_bound)
|| (sizes.text_bound > sizes.data_base || (sizes.text_bound > sizes.data_base
&& sizes.text_bound <= sizes.data_bound) && sizes.text_bound <= sizes.data_bound)
|| (sizes.text_base >= sizes.data_base || (sizes.text_base >= sizes.data_base