FreeChainXenon/binutils-gdb
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Use auto_obstack in objfile

Browse source 
This changes objfile to use an auto_obstack.  This helps prevent
use-after-free bugs, because it ensures that anything allocated on the
objfile obstack will live past the point at which the registry object
is destroyed.
This commit is contained in:
Tom Tromey 2022-08-02 11:57:20 -06:00
parent 98badbfdc2
commit 075e4d6d95
2 changed files with 1 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

7
gdb/objfiles.c
View file

@ -324,10 +324,6 @@ objfile::objfile (gdb_bfd_ref_ptr bfd_, const char *name, objfile_flags flags_)
{
const char *expanded_name;
/* We could use obstack_specify_allocation here instead, but
gdb_obstack.h specifies the alloc/dealloc functions. */
obstack_init (&objfile_obstack);
std::string name_holder;
if (name == NULL)
{
@ -583,9 +579,6 @@ objfile::~objfile ()
clear_current_source_symtab_and_line ();
}
/* Free the obstacks for non-reusable objfiles. */
obstack_free (&objfile_obstack, 0);
/* Rebuild section map next time we need it. */
get_objfile_pspace_data (pspace)->section_map_dirty = 1;
}