FreeChainXenon/binutils-gdb
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Change get_filename_and_charpos to return void

Browse source 
The return value from get_filename_and_charpos is never used, so this
patch changes it to return void.

gdb/ChangeLog
2018-11-19  Tom Tromey  <tom@tromey.com>

	* source.c (get_filename_and_charpos): Return void.
This commit is contained in:
Tom Tromey 2018-10-09 14:31:15 -06:00
parent 261f6f7962
commit 0614ef69be
2 changed files with 6 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
gdb/ChangeLog
View file

@ -1,3 +1,7 @@
2018-11-19 Tom Tromey <tom@tromey.com>
* source.c (get_filename_and_charpos): Return void.
2018-11-19 Simon Marchi <simon.marchi@polymtl.ca>
* skip.c (_initialize_step_skip): Fix "info skip" help.

14
gdb/source.c
View file

@ -49,10 +49,6 @@
#define OPEN_MODE (O_RDONLY | O_BINARY)
#define FDOPEN_MODE FOPEN_RB
/* Prototypes for local functions. */
static int get_filename_and_charpos (struct symtab *, char **);
/* Path of directories to search for source files.
Same format as the PATH environment variable's value. */
@ -1209,29 +1205,23 @@ find_source_lines (struct symtab *s, int desc)
/* Get full pathname and line number positions for a symtab.
Return nonzero if line numbers may have changed.
Set *FULLNAME to actual name of the file as found by `openp',
or to 0 if the file is not found. */
static int
static void
get_filename_and_charpos (struct symtab *s, char **fullname)
{
int linenums_changed = 0;
scoped_fd desc = open_source_file (s);
if (desc.get () < 0)
{
if (fullname)
*fullname = NULL;
return 0;
return;
}
if (fullname)
*fullname = s->fullname;
if (s->line_charpos == 0)
linenums_changed = 1;
if (linenums_changed)
find_source_lines (s, desc.get ());
return linenums_changed;
}
/* Print text describing the full name of the source file S