FreeChainXenon/binutils-gdb
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Don't use wchar_printable in print_wchar

Browse source 
print_wchar uses wchar_printable, but this isn't needed -- all the
relevant cases are already handled by the 'switch'.  This changes the
code to use gdb_iswprint, and removes a somewhat confusing comment
related to this code.
This commit is contained in:
Tom Tromey 2022-02-11 18:24:23 -07:00
parent 3a3bb6eb36
commit 05328f9105
1 changed files with 5 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
gdb/valprint.c
View file

@ -2081,9 +2081,8 @@ print_wchar (gdb_wint_t w, const gdb_byte *orig,
*need_escapep = false;
/* iswprint implementation on Windows returns 1 for tab character.
In order to avoid different printout on this host, we explicitly
use wchar_printable function. */
/* If any additional cases are added to this switch block, then the
function wchar_printable will likely need updating too. */
switch (w)
{
case LCST ('\a'):
@ -2109,9 +2108,9 @@ print_wchar (gdb_wint_t w, const gdb_byte *orig,
break;
default:
{
if (wchar_printable (w) && (!need_escape || (!gdb_iswdigit (w)
&& w != LCST ('8')
&& w != LCST ('9'))))
if (gdb_iswprint (w) && (!need_escape || (!gdb_iswdigit (w)
&& w != LCST ('8')
&& w != LCST ('9'))))
{
gdb_wchar_t wchar = w;