FreeChainXenon/binutils-gdb
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

gdb/options: fix copy&paste error in string_option_def

Browse source 
Spotted what appears to be a copy&paste error in string_option_def,
the code for string handling writes the address fetching callback
function into the option_def::var_address::enumeration location,
rather than option_def::var_address::string.

Of course, this works just fine as option_def::var_address is a union,
and all of its members are function pointers, so they're going to be
the same size on every target GDB cares about.

But it doesn't hurt to be correct, so fixed in this commit.

There should be no user visible changes after this commit.
This commit is contained in:
Andrew Burgess 2023-12-14 11:54:13 +00:00
parent f5d420bbce
commit 03ce4e1bdb
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
gdb/cli/cli-option.h
View file

@ -304,7 +304,7 @@ struct string_option_def : option_def
show_cmd_cb_,
set_doc_, show_doc_, help_doc_)
{
var_address.enumeration = detail::get_var_address<const char *, Context>;
var_address.string = detail::get_var_address<std::string, Context>;
}
};