FreeChainXenon/binutils-gdb
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Do not use std::move when assigning an anonymous object to a unique_ptr.

Browse source 
Using std::move forces an extra copy of the object.  These changes fix
-Wpessimizing-move warnings from clang.

gdb/ChangeLog:

	* ada-lang.c (create_excep_cond_exprs): Do not use 'std::move'.
	* ax-gdb.c (agent_eval_command_one): Likewise.
	(agent_eval_command_one): Likewise.
	* breakpoint.c (parse_cond_to_aexpr): Likewise.
	(parse_cmd_to_aexpr): Likewise.
	* dtrace-probe.c (dtrace_process_dof_probe): Likewise.
	* parse.c (parse_expression_for_completion): Likewise.
This commit is contained in:
John Baldwin 2016-11-24 12:01:24 -08:00
parent bbe910e6e1
commit 036e657b48
6 changed files with 23 additions and 14 deletions
Download patch file Download diff file Expand all files Collapse all files

10
gdb/ChangeLog
View file

@ -1,3 +1,13 @@
2016-11-24 John Baldwin <jhb@FreeBSD.org>
* ada-lang.c (create_excep_cond_exprs): Do not use 'std::move'.
* ax-gdb.c (agent_eval_command_one): Likewise.
(agent_eval_command_one): Likewise.
* breakpoint.c (parse_cond_to_aexpr): Likewise.
(parse_cmd_to_aexpr): Likewise.
* dtrace-probe.c (dtrace_process_dof_probe): Likewise.
* parse.c (parse_expression_for_completion): Likewise.
2016-11-24 John Baldwin <jhb@FreeBSD.org> 2016-11-24 John Baldwin <jhb@FreeBSD.org>
* common/new-op.c (operator new): Mark 'noexcept'. * common/new-op.c (operator new): Mark 'noexcept'.

6
gdb/ada-lang.c
View file

@ -12343,9 +12343,9 @@ create_excep_cond_exprs (struct ada_catchpoint *c)
s = cond_string; s = cond_string;
TRY TRY
{ {
exp = std::move (parse_exp_1 (&s, bl->address, exp = parse_exp_1 (&s, bl->address,
block_for_pc (bl->address), block_for_pc (bl->address),
0)); 0);
} }
CATCH (e, RETURN_MASK_ERROR) CATCH (e, RETURN_MASK_ERROR)
{ {

8
gdb/ax-gdb.c
View file

@ -2555,8 +2555,8 @@ agent_eval_command_one (const char *exp, int eval, CORE_ADDR pc)
arg = exp; arg = exp;
if (!eval && strcmp (arg, "$_ret") == 0) if (!eval && strcmp (arg, "$_ret") == 0)
{ {
agent = std::move (gen_trace_for_return_address (pc, get_current_arch (), agent = gen_trace_for_return_address (pc, get_current_arch (),
trace_string)); trace_string);
} }
else else
{ {
@ -2565,10 +2565,10 @@ agent_eval_command_one (const char *exp, int eval, CORE_ADDR pc)
if (eval) if (eval)
{ {
gdb_assert (trace_string == 0); gdb_assert (trace_string == 0);
agent = std::move (gen_eval_for_expr (pc, expr.get ())); agent = gen_eval_for_expr (pc, expr.get ());
} }
else else
agent = std::move (gen_trace_for_expr (pc, expr.get (), trace_string)); agent = gen_trace_for_expr (pc, expr.get (), trace_string);
} }
ax_reqs (agent.get ()); ax_reqs (agent.get ());

8
gdb/breakpoint.c
View file

@ -2268,7 +2268,7 @@ parse_cond_to_aexpr (CORE_ADDR scope, struct expression *cond)
that may show up. */ that may show up. */
TRY TRY
{ {
aexpr = std::move (gen_eval_for_expr (scope, cond)); aexpr = gen_eval_for_expr (scope, cond);
} }
CATCH (ex, RETURN_MASK_ERROR) CATCH (ex, RETURN_MASK_ERROR)
@ -2452,9 +2452,9 @@ parse_cmd_to_aexpr (CORE_ADDR scope, char *cmd)
that may show up. */ that may show up. */
TRY TRY
{ {
aexpr = std::move (gen_printf (scope, gdbarch, 0, 0, aexpr = gen_printf (scope, gdbarch, 0, 0,
format_start, format_end - format_start, format_start, format_end - format_start,
fpieces, nargs, argvec)); fpieces, nargs, argvec);
} }
CATCH (ex, RETURN_MASK_ERROR) CATCH (ex, RETURN_MASK_ERROR)
{ {

3
gdb/dtrace-probe.c
View file

@ -430,8 +430,7 @@ dtrace_process_dof_probe (struct objfile *objfile,
TRY TRY
{ {
expr = std::move (parse_expression_with_language (arg.type_str, expr = parse_expression_with_language (arg.type_str, language_c);
language_c));
} }
CATCH (ex, RETURN_MASK_ERROR) CATCH (ex, RETURN_MASK_ERROR)
{ {

2
gdb/parse.c
View file

@ -1309,7 +1309,7 @@ parse_expression_for_completion (const char *string, char **name,
TRY TRY
{ {
parse_completion = 1; parse_completion = 1;
exp = std::move (parse_exp_in_context (&string, 0, 0, 0, 0, &subexp)); exp = parse_exp_in_context (&string, 0, 0, 0, 0, &subexp);
} }
CATCH (except, RETURN_MASK_ERROR) CATCH (except, RETURN_MASK_ERROR)
{ {