* object.h (class Object): Remove target_ field, and target,
sized_target, and set_target methods. (Object::sized_target): Remove. (class Sized_relobj): Update declarations. Remove sized_target. * object.cc (Sized_relobj::setup): Remove target parameter. Change all callers. (Input_objects::add_object): Don't do anything with the target. (make_elf_sized_object): Add punconfigured parameter. Change all callers. Set or test parameter target. * dynobj.cc (Sized_dynobj::target): Remove target parameter. Change all callers. * parameters.cc (Parameters::set_target): Change parameter type to be non-const. (Parameters::default_target): Remove. (set_parameters_target): Change parameter type to be non-const. (parameters_force_valid_target): New function. (parameters_clear_target): New function. * parameters.h (class Parameters): Update declarations. Remove default_target method. Add sized_target and clear_target methods. Change target_ to be non-const. (set_parameters_target): Update declaration. (parameters_force_valid_target): Declare. (parameters_clear_target): Declare. * readsyms.cc (Read_symbols::do_read_symbols): Pass punconfigured as NULL if we aren't searching. (Add_symbols::run): Don't check for compatible target. * fileread.cc (Input_file::open_binary): Call parameters_force_valid_target. * gold.cc (queue_middle_tasks): Likewise. * plugin.cc (make_sized_plugin_object): Likewise. Don't call set_target on object. * dynobj.h (class Sized_dynobj): Update declarations. * archive.cc (Archive::get_elf_object_for_member): Return NULL if make_elf_object returns NULL. (Archive::include_member): Don't check whether object target is compatible. * output.cc (Output_section::add_input_section): Get target from parameters. (Output_section::relax_input_section): Likewise. * reloc.cc (Sized_relobj::do_gc_process_relocs): Get target from parameters. (Sized_relobj::do_scan_relocs): Likewise. (Sized_relobj::relocate_sections): Likewise. * resolve.cc (Symbol_table::resolve): Likewise. * symtab.cc (Symbol_table::wrap_symbol): Likewise. Remove object parameter. Change all callers. (Symbol_table::add_from_object): Get target from parameters. (Symbol_table::add_from_relobj): Don't check object target. (Symbol_table::add_from_dynobj): Likewise. (Symbol_table::define_special_symbol): Get target from parameters. * symtab.h (class Symbol_table): Update declaration. * testsuite/binary_unittest.cc (gold_testsuite): Remove target parameter. Change all callers. Clear parameter target. (Binary_test): Test target here. * testsuite/object_unittest.cc (gold_testsuite): Remove target_test_pointer parameter. Change all callers. (Object_test): Test target here.
This commit is contained in:
parent
27a5525e75
commit
029ba97335
20 changed files with 227 additions and 188 deletions
|
@ -336,14 +336,12 @@ Sized_relobj<size, big_endian>::~Sized_relobj()
|
|||
}
|
||||
|
||||
// Set up an object file based on the file header. This sets up the
|
||||
// target and reads the section information.
|
||||
// section information.
|
||||
|
||||
template<int size, bool big_endian>
|
||||
void
|
||||
Sized_relobj<size, big_endian>::setup(Target *target)
|
||||
Sized_relobj<size, big_endian>::setup()
|
||||
{
|
||||
this->set_target(target);
|
||||
|
||||
const unsigned int shnum = this->elf_file_.shnum();
|
||||
this->set_shnum(shnum);
|
||||
}
|
||||
|
@ -2067,16 +2065,6 @@ Sized_relobj<size, big_endian>::do_get_global_symbol_counts(
|
|||
bool
|
||||
Input_objects::add_object(Object* obj)
|
||||
{
|
||||
// Set the global target from the first object file we recognize.
|
||||
Target* target = obj->target();
|
||||
if (!parameters->target_valid())
|
||||
set_parameters_target(target);
|
||||
else if (target != ¶meters->target())
|
||||
{
|
||||
obj->error(_("incompatible target"));
|
||||
return false;
|
||||
}
|
||||
|
||||
// Print the filename if the -t/--trace option is selected.
|
||||
if (parameters->options().trace())
|
||||
gold_info("%s", obj->name().c_str());
|
||||
|
@ -2227,7 +2215,8 @@ using namespace gold;
|
|||
template<int size, bool big_endian>
|
||||
Object*
|
||||
make_elf_sized_object(const std::string& name, Input_file* input_file,
|
||||
off_t offset, const elfcpp::Ehdr<size, big_endian>& ehdr)
|
||||
off_t offset, const elfcpp::Ehdr<size, big_endian>& ehdr,
|
||||
bool* punconfigured)
|
||||
{
|
||||
Target* target = select_target(ehdr.get_e_machine(), size, big_endian,
|
||||
ehdr.get_e_ident()[elfcpp::EI_OSABI],
|
||||
|
@ -2235,6 +2224,18 @@ make_elf_sized_object(const std::string& name, Input_file* input_file,
|
|||
if (target == NULL)
|
||||
gold_fatal(_("%s: unsupported ELF machine number %d"),
|
||||
name.c_str(), ehdr.get_e_machine());
|
||||
|
||||
if (!parameters->target_valid())
|
||||
set_parameters_target(target);
|
||||
else if (target != ¶meters->target())
|
||||
{
|
||||
if (punconfigured != NULL)
|
||||
*punconfigured = true;
|
||||
else
|
||||
gold_error(_("%s: incompatible target"), name.c_str());
|
||||
return NULL;
|
||||
}
|
||||
|
||||
return target->make_elf_object<size, big_endian>(name, input_file, offset,
|
||||
ehdr);
|
||||
}
|
||||
|
@ -2337,7 +2338,7 @@ make_elf_object(const std::string& name, Input_file* input_file, off_t offset,
|
|||
#ifdef HAVE_TARGET_32_BIG
|
||||
elfcpp::Ehdr<32, true> ehdr(p);
|
||||
return make_elf_sized_object<32, true>(name, input_file,
|
||||
offset, ehdr);
|
||||
offset, ehdr, punconfigured);
|
||||
#else
|
||||
if (punconfigured != NULL)
|
||||
*punconfigured = true;
|
||||
|
@ -2353,7 +2354,7 @@ make_elf_object(const std::string& name, Input_file* input_file, off_t offset,
|
|||
#ifdef HAVE_TARGET_32_LITTLE
|
||||
elfcpp::Ehdr<32, false> ehdr(p);
|
||||
return make_elf_sized_object<32, false>(name, input_file,
|
||||
offset, ehdr);
|
||||
offset, ehdr, punconfigured);
|
||||
#else
|
||||
if (punconfigured != NULL)
|
||||
*punconfigured = true;
|
||||
|
@ -2377,7 +2378,7 @@ make_elf_object(const std::string& name, Input_file* input_file, off_t offset,
|
|||
#ifdef HAVE_TARGET_64_BIG
|
||||
elfcpp::Ehdr<64, true> ehdr(p);
|
||||
return make_elf_sized_object<64, true>(name, input_file,
|
||||
offset, ehdr);
|
||||
offset, ehdr, punconfigured);
|
||||
#else
|
||||
if (punconfigured != NULL)
|
||||
*punconfigured = true;
|
||||
|
@ -2393,7 +2394,7 @@ make_elf_object(const std::string& name, Input_file* input_file, off_t offset,
|
|||
#ifdef HAVE_TARGET_64_LITTLE
|
||||
elfcpp::Ehdr<64, false> ehdr(p);
|
||||
return make_elf_sized_object<64, false>(name, input_file,
|
||||
offset, ehdr);
|
||||
offset, ehdr, punconfigured);
|
||||
#else
|
||||
if (punconfigured != NULL)
|
||||
*punconfigured = true;
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue