binutils-gdb/gdb/python/py-record.c

250 lines
6.8 KiB
C
Raw Normal View History

/* Python interface to record targets.
Copyright 2016-2017 Free Software Foundation, Inc.
This file is part of GDB.
This program is free software; you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
the Free Software Foundation; either version 3 of the License, or
(at your option) any later version.
This program is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
GNU General Public License for more details.
You should have received a copy of the GNU General Public License
along with this program. If not, see <http://www.gnu.org/licenses/>. */
#include "defs.h"
#include "py-record.h"
#include "py-record-btrace.h"
#include "py-record-full.h"
#include "target.h"
/* Python Record type. */
static PyTypeObject recpy_record_type = {
PyVarObject_HEAD_INIT (NULL, 0)
};
/* Implementation of record.method. */
static PyObject *
recpy_method (PyObject *self, void* closure)
{
const recpy_record_object * const obj = (recpy_record_object *) self;
if (obj->method == RECORD_METHOD_FULL)
return recpy_full_method (self, closure);
if (obj->method == RECORD_METHOD_BTRACE)
return recpy_bt_method (self, closure);
return PyErr_Format (PyExc_NotImplementedError, _("Not implemented."));
}
/* Implementation of record.format. */
static PyObject *
recpy_format (PyObject *self, void* closure)
{
const recpy_record_object * const obj = (recpy_record_object *) self;
if (obj->method == RECORD_METHOD_FULL)
return recpy_full_format (self, closure);
if (obj->method == RECORD_METHOD_BTRACE)
return recpy_bt_format (self, closure);
return PyErr_Format (PyExc_NotImplementedError, _("Not implemented."));
}
/* Implementation of record.goto (instruction) -> None. */
static PyObject *
recpy_goto (PyObject *self, PyObject *value)
{
const recpy_record_object * const obj = (recpy_record_object *) self;
if (obj->method == RECORD_METHOD_BTRACE)
return recpy_bt_goto (self, value);
return PyErr_Format (PyExc_NotImplementedError, _("Not implemented."));
}
/* Implementation of record.replay_position [instruction] */
static PyObject *
recpy_replay_position (PyObject *self, void *closure)
{
const recpy_record_object * const obj = (recpy_record_object *) self;
if (obj->method == RECORD_METHOD_BTRACE)
return recpy_bt_replay_position (self, closure);
return PyErr_Format (PyExc_NotImplementedError, _("Not implemented."));
}
/* Implementation of record.instruction_history [list]. */
static PyObject *
recpy_instruction_history (PyObject *self, void* closure)
{
const recpy_record_object * const obj = (recpy_record_object *) self;
if (obj->method == RECORD_METHOD_BTRACE)
return recpy_bt_instruction_history (self, closure);
return PyErr_Format (PyExc_NotImplementedError, _("Not implemented."));
}
/* Implementation of record.function_call_history [list]. */
static PyObject *
recpy_function_call_history (PyObject *self, void* closure)
{
const recpy_record_object * const obj = (recpy_record_object *) self;
if (obj->method == RECORD_METHOD_BTRACE)
return recpy_bt_function_call_history (self, closure);
return PyErr_Format (PyExc_NotImplementedError, _("Not implemented."));
}
/* Implementation of record.begin [instruction]. */
static PyObject *
recpy_begin (PyObject *self, void* closure)
{
const recpy_record_object * const obj = (recpy_record_object *) self;
if (obj->method == RECORD_METHOD_BTRACE)
return recpy_bt_begin (self, closure);
return PyErr_Format (PyExc_NotImplementedError, _("Not implemented."));
}
/* Implementation of record.end [instruction]. */
static PyObject *
recpy_end (PyObject *self, void* closure)
{
const recpy_record_object * const obj = (recpy_record_object *) self;
if (obj->method == RECORD_METHOD_BTRACE)
return recpy_bt_end (self, closure);
return PyErr_Format (PyExc_NotImplementedError, _("Not implemented."));
}
/* Record method list. */
static PyMethodDef recpy_record_methods[] = {
{ "goto", recpy_goto, METH_VARARGS,
"goto (instruction|function_call) -> None.\n\
Rewind to given location."},
{ NULL }
};
/* Record member list. */
-Wwrite-strings: Wrap PyGetSetDef for construction with string literals Unfortunately, PyGetSetDef's 'name' and 'doc' members are 'char *' instead of 'const char *', meaning that in order to list-initialize PyGetSetDef arrays using string literals requires writing explicit 'char *' casts. For example: static PyGetSetDef value_object_getset[] = { - { "address", valpy_get_address, NULL, "The address of the value.", + { (char *) "address", valpy_get_address, NULL, + (char *) "The address of the value.", NULL }, - { "is_optimized_out", valpy_get_is_optimized_out, NULL, - "Boolean telling whether the value is optimized " + { (char *) "is_optimized_out", valpy_get_is_optimized_out, NULL, + (char *) "Boolean telling whether the value is optimized " "out (i.e., not available).", NULL }, - { "type", valpy_get_type, NULL, "Type of the value.", NULL }, - { "dynamic_type", valpy_get_dynamic_type, NULL, - "Dynamic type of the value.", NULL }, - { "is_lazy", valpy_get_is_lazy, NULL, - "Boolean telling whether the value is lazy (not fetched yet\n\ + { (char *) "type", valpy_get_type, NULL, + (char *) "Type of the value.", NULL }, + { (char *) "dynamic_type", valpy_get_dynamic_type, NULL, + (char *) "Dynamic type of the value.", NULL }, + { (char *) "is_lazy", valpy_get_is_lazy, NULL, + (char *) "Boolean telling whether the value is lazy (not fetched yet\n\ from the inferior). A lazy value is fetched when needed, or when\n\ the \"fetch_lazy()\" method is called.", NULL }, {NULL} /* Sentinel */ We have ~20 such arrays, and I first wrote a patch that fixed all of them like that... It's not pretty... One way to make these a bit less ugly would be add a new macro that hides the casts, like: #define GDBPY_GSDEF(NAME, GET, SET, DOC, CLOSURE) \ { (char *) NAME, GET, SET, (char *) DOC, CLOSURE } and then use it like: static PyGetSetDef value_object_getset[] = { GDBPY_GSDEF ("address", valpy_get_address, NULL, "The address of the value.", NULL), GDBPY_GSDEF ("is_optimized_out", valpy_get_is_optimized_out, NULL, "Boolean telling whether the value is optimized ", NULL), {NULL} /* Sentinel */ }; But since we have C++11, which gives us constexpr and list initialization, I thought of a way that requires no changes where the arrays are initialized: We add a new type that extends PyGetSetDef (called gdb_PyGetSetDef), and add constexpr constructors that accept const 'name' and 'doc', and then list/aggregate initialization simply "calls" these matching constructors instead. I put "calls" in quotes, because given "constexpr", it's all done at compile time, and there's no overhead either in binary size or at run time. In fact, we get identical binaries, before/after this change. Unlike the fixes that fix some old Python API to match the API of more recent Python, this switches to using explicit "gdb_PyGetSetDef" everywhere, just to be clear that we are using our own version of it. gdb/ChangeLog: 2017-04-05 Pedro Alves <palves@redhat.com> * python/python-internal.h (gdb_PyGetSetDef): New type. * python/py-block.c (block_object_getset) (breakpoint_object_getset): Now a gdb_PyGetSetDef array. * python/py-event.c (event_object_getset) (finish_breakpoint_object_getset): Likewise. * python/py-inferior.c (inferior_object_getset): Likewise. * python/py-infthread.c (thread_object_getset): Likewise. * python/py-lazy-string.c (lazy_string_object_getset): Likewise. * python/py-linetable.c (linetable_entry_object_getset): Likewise. * python/py-objfile.c (objfile_getset): Likewise. * python/py-progspace.c (pspace_getset): Likewise. * python/py-record-btrace.c (btpy_insn_getset, btpy_call_getset): Likewise. * python/py-record.c (recpy_record_getset): Likewise. * python/py-symbol.c (symbol_object_getset): Likewise. * python/py-symtab.c (symtab_object_getset, sal_object_getset): Likewise. * python/py-type.c (type_object_getset, field_object_getset): Likewise. * python/py-value.c (value_object_getset): Likewise.
2017-04-05 19:21:36 +01:00
static gdb_PyGetSetDef recpy_record_getset[] = {
{ "method", recpy_method, NULL, "Current recording method.", NULL },
{ "format", recpy_format, NULL, "Current recording format.", NULL },
{ "replay_position", recpy_replay_position, NULL, "Current replay position.",
NULL },
{ "instruction_history", recpy_instruction_history, NULL,
"List of instructions in current recording.", NULL },
{ "function_call_history", recpy_function_call_history, NULL,
"List of function calls in current recording.", NULL },
{ "begin", recpy_begin, NULL,
"First instruction in current recording.", NULL },
{ "end", recpy_end, NULL,
"One past the last instruction in current recording. This is typically \
the current instruction and is used for e.g. record.goto (record.end).", NULL },
{ NULL }
};
/* Sets up the record API in the gdb module. */
int
gdbpy_initialize_record (void)
{
recpy_record_type.tp_new = PyType_GenericNew;
recpy_record_type.tp_flags = Py_TPFLAGS_DEFAULT;
recpy_record_type.tp_basicsize = sizeof (recpy_record_object);
recpy_record_type.tp_name = "gdb.Record";
recpy_record_type.tp_doc = "GDB record object";
recpy_record_type.tp_methods = recpy_record_methods;
recpy_record_type.tp_getset = recpy_record_getset;
return PyType_Ready (&recpy_record_type);
}
/* Implementation of gdb.start_recording (method) -> gdb.Record. */
PyObject *
gdbpy_start_recording (PyObject *self, PyObject *args)
{
const char *method = NULL;
const char *format = NULL;
PyObject *ret = NULL;
if (!PyArg_ParseTuple (args, "|ss", &method, &format))
return NULL;
TRY
{
record_start (method, format, 0);
ret = gdbpy_current_recording (self, args);
}
CATCH (except, RETURN_MASK_ALL)
{
gdbpy_convert_exception (except);
}
END_CATCH
return ret;
}
/* Implementation of gdb.current_recording (self) -> gdb.Record. */
PyObject *
gdbpy_current_recording (PyObject *self, PyObject *args)
{
recpy_record_object *ret = NULL;
if (find_record_target () == NULL)
Py_RETURN_NONE;
ret = PyObject_New (recpy_record_object, &recpy_record_type);
ret->ptid = inferior_ptid;
ret->method = target_record_method (inferior_ptid);
return (PyObject *) ret;
}
/* Implementation of gdb.stop_recording (self) -> None. */
PyObject *
gdbpy_stop_recording (PyObject *self, PyObject *args)
{
PyObject *ret = NULL;
TRY
{
record_stop (0);
ret = Py_None;
Py_INCREF (Py_None);
}
CATCH (except, RETURN_MASK_ALL)
{
gdbpy_convert_exception (except);
}
END_CATCH
return ret;
}